Addition of EMS Inside Face Material Absorptance Control - #11758
Addition of EMS Inside Face Material Absorptance Control#11758RKStrand wants to merge 9 commits into
Conversation
This commit includes code to expand the ability to control the inside face thermal and solar absorptance via EMS in EnergyPlus. Code is working as expected (all four absorptances for a surface are being modified correctly--thermal and solar, inside and outside face) and existing unit tests have been updated and energyplus_tests runs successfully to completion.
This commit includes a significant enhancement of an existing unit test that tests the new construction absorptance EMS input and more thorough tests the six material based EMS parameters. In addition, changes were made to the EMS Guide in read the docs.
Forgot to include the new input file and the requisite edit to CMakeLists.txt
|
Thank you @RKStrand! In case you didn't already update it, note the final two sentences in the documentation here:
|
|
@shorowit Yes, I did make a small tweak there. Here is what it now says: Note that the variable-absorptance coatings modeled with this object are not exactly equivalent to those modeled Thoughts on that update? |
|
@RKStrand I was under the impression that the two approaches were previously not exactly equivalent because of which sides of the material they impact. But if they can both impact either (or both) sides of the material, aren't they now equivalent? I guess I would have expected something simply like "Note that the variable-absorptance coatings modeled with this object can also be modeled with EMS." |
|
@shorowit Yeah, I like your suggestion--simple and straight to the point. No need for additional verbiage. EMS gives you "more" control at the expense of having to do some programming in the input file on your own. I'll make another commit that uses your suggestion here. |
|
|
Keep existing absorptance actuators controlling both material faces while adding explicit inside- and outside-face actuators. Give face-specific controls precedence, update documentation and the example file, and add regression coverage for legacy behavior.
|
|
Restore material input values when face-specific actuators are set to Null and preserve face-specific actuator precedence over legacy controls. Register separate inside- and outside-face absorptance output variables for surfaces controlled by EMS. Expand regression coverage and stabilize the EMS absorptance example file.
|
|
|
@RKStrand can you take another look here? I think this one is pretty close. |
4 participants
Pull request overview
Description of the purpose of this PR
Following on the work done to allow Material, Material:NoMass, and MaterialProperty:VariableAbsorptance to specifically modify the inside face absorptances of material layers separately from the outside face, this work includes changes that allow this same functionality via the EMS feature of EnergyPlus. This work includes code revisions, a significantly expanded unit test, updated documentation, and a new input file that demonstrates in a simply way how to modify these parameters using EMS. No changes in current output are expected.
Pull Request Author
Reviewer