Skip to content

Add design load reporting for convective water baseboard autosizing#11634

Merged
mitchute merged 5 commits into
developfrom
4957-Baseboard-Load-Reporting
Jun 11, 2026
Merged

Add design load reporting for convective water baseboard autosizing#11634
mitchute merged 5 commits into
developfrom
4957-Baseboard-Load-Reporting

Conversation

@rraustad

@rraustad rraustad commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Pull request overview

Test files:

  • 5ZoneCoolBeam
  • 5ZoneCoolingPanelBaseboard

Description of the purpose of this PR

User request for design load used for autosizing convective water baseboards.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Jun 9, 2026
@rraustad

rraustad commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Develop:

image image

This branch:

image image

eio example:

Component Sizing Information, ZoneHVAC:Baseboard:Convective:Water, SPACE1-1 HW COIL, Design Size Heating Load [W], 1878.88
Component Sizing Information, ZoneHVAC:Baseboard:Convective:Water, SPACE1-1 HW COIL, Design Size Maximum Water Flow Rate [m3/s], 4.15116E-05
Component Sizing Information, ZoneHVAC:Baseboard:Convective:Water, SPACE1-1 HW COIL, Design Size U-Factor Times Area Value [W/K], 44.6695

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit c382c57

Regression Summary
  • Audit: 13
  • EIO: 13
  • Table Big Diffs: 13

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit 074a400

Regression Summary
  • Audit: 13
  • EIO: 13
  • Table Big Diffs: 13

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ Regressions detected on macos-14 for commit c382c57

Regression Summary
  • Audit: 13
  • EIO: 13
  • Table Big Diffs: 13

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ Regressions detected on macos-14 for commit 074a400

Regression Summary
  • Audit: 13
  • EIO: 13
  • Table Big Diffs: 13

mitchute
mitchute reviewed Jun 10, 2026
View reviewed changes

@mitchute mitchute left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rraustad. There were a couple related things I found that are outside of the original issue. I'm flagging them here for your consideration. OK to handle those separately, if needed. The rest of the PR looks good.

Comment thread src/EnergyPlus/HWBaseboardRadiator.cc Outdated
Comment thread src/EnergyPlus/HWBaseboardRadiator.cc
Comment on lines 1008 to 1012
if (hWBaseboard.ScaledHeatingCapacity == DataSizing::AutoSize) {
CheckZoneSizing(state, CompType, CompName);
zoneEqSizing.HeatingCapacity = true;
zoneEqSizing.DesHeatingLoad = state.dataSize->FinalZoneSizing(state.dataSize->CurZoneEqNum).NonAirSysDesHeatLoad;
}

@mitchute mitchute Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DesHeatingLoad is not set when DataSizing::HeatingDesignCapacity and hWBaseboard.ScaledHeatingCapacity != DataSizing::AutoSize. Is that a valid path? It seems like it would be based on this:

EnergyPlus/src/EnergyPlus/BaseboardRadiator.cc

Lines 620 to 625 in a3098ea

if (CapSizingMethod == DataSizing::HeatingDesignCapacity) {
if (this->ScaledHeatingCapacity == DataSizing::AutoSize) {
zoneEqSizing.DesHeatingLoad = finalZoneSizing.NonAirSysDesHeatLoad;
} else {
zoneEqSizing.DesHeatingLoad = this->ScaledHeatingCapacity;
}

@rraustad rraustad Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hard sized the baseboards to 2000 W and ScaledHeatingCapacity came through as 2000. I decided to just report the zone load for both baseboard types regardless of CapSizingMethod. If a zone sizing run is not performed then this column will not show in the table (or only zones that are sized will have data).

Comment thread src/EnergyPlus/BaseboardRadiator.cc Outdated
Comment thread src/EnergyPlus/HWBaseboardRadiator.cc Outdated
Comment on lines +1042 to +1043
BaseSizer::reportSizerOutput(
state, cCMO_BBRadiator_Water, hWBaseboard.Name, "Design Size Heating Load [W]", zoneEqSizing.DesHeatingLoad);

@mitchute mitchute Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that you're intending to report the design load, not the coil size with any scaling factors applied. If that's not right, let me know.

@rraustad rraustad Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's a good point. I was trying to report the load used to size the baseboard, however that load was determined. It's either NonAirSysDesHeatLoad for 2 of the cases or ScaledHeatingCapacity * FloorArea for CapacityPerFloorArea. I'm OK with reporting NonAirSysDesHeatLoad for all cases but then how to tell the user that this load is not what actually sized the baseboard for CapacityPerFloorArea? Another column for sizing method?

@mitchute mitchute Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume that sort of information would be useful, but I'm not sure what most users are looking for. I personally think it would be informative to know the load and the coil size separately. I don't know if the sizing method needs to be reported via the table since that's already in the inputs.

TLDR - I defer to you 😄

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit 033238b

Regression Summary
  • Audit: 13
  • EIO: 13
  • Table Big Diffs: 13

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

⚠️ Regressions detected on macos-14 for commit 033238b

Regression Summary
  • Audit: 13
  • EIO: 13
  • Table Big Diffs: 13

mitchute
mitchute approved these changes Jun 11, 2026
View reviewed changes

@mitchute mitchute left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rraustad. Looks good.

@mitchute mitchute merged commit 673f718 into develop Jun 11, 2026
11 checks passed
@mitchute mitchute deleted the 4957-Baseboard-Load-Reporting branch June 11, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute mitchute approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ZoneHVAC:Baseboard:Convective:Water and RadiantConvective:Water should report capacity

3 participants

@rraustad @mitchute @nrel-bot-2c