Skip to content

Fix #11631 - Latest release failed on Windows arm64 and on mac#11632

Merged
mitchute merged 4 commits into
developfrom
fixup_windows_arm
Jun 10, 2026
Merged

Fix #11631 - Latest release failed on Windows arm64 and on mac#11632
mitchute merged 4 commits into
developfrom
fixup_windows_arm

Conversation

@jmarrec

@jmarrec jmarrec commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Jun 9, 2026
@jmarrec jmarrec self-assigned this Jun 9, 2026
Comment thread .github/workflows/release_windows.yml Outdated
Comment on lines +149 to +152
Python_EXECUTABLE="${{ steps.setup-python.outputs.python-path }}"
echo "Python_EXECUTABLE=$Python_EXECUTABLE"
Python_ROOT_DIR=$(dirname "${Python_EXECUTABLE//\\//}")
echo "Python_ROOT_DIR=$Python_ROOT_DIR"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows arm64

cmake -G ‘Visual Studio 17 2022’ -A ARM64 -DLINK_WITH_PYTHON:BOOL=ON -DPYTHON_CLI:BOOL=ON -DPython_REQUIRED_VERSION:STRING=3.12.10 ‘-DPython_ROOT_DIR:PATH=C:\hostedtoolcache\windows/Python/3.12.10/arm64/’ -DBUILD_FORTRAN:BOOL=ON -DBUILD_PACKAGE:BOOL=ON -DENABLE_HARDENED_RUNTIME:BOOL=OFF -DDOCUMENTATION_BUILD:STRING=BuildWithAll -DTEX_INTERACTION:STRING=batchmode ../

I'm guessing the issue might be the backslashes in -DPython_ROOT_DIR:PATH=C:\hostedtoolcache\windows/Python/3.12.10/arm64/’

CMake Error at C:/Program Files/CMake/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
  Could NOT find Python (missing: Python_EXECUTABLE Interpreter) (found
  suitable exact version "3.12.10")

      Reason given by package:
          Interpreter: Wrong version for the interpreter "C:/hostedtoolcache/windows/Python/3.13.13/arm64/python.exe"

Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:654 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-4.3/Modules/FindPython/Support.cmake:4334 (find_package_handle_standard_args)
  C:/Program Files/CMake/share/cmake-4.3/Modules/FindPython.cmake:700 (include)
  CMakeLists.txt:190 (find_package)

The step setup-python, with debug output enabled

##[debug]Added matchers: ‘python’. Problem matchers scan action output for known warning or error strings and report these inline.
##[debug]Node Action run completed with exit code 0
##[debug]pythonLocation=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]PKG_CONFIG_PATH=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64/lib/pkgconfig’
##[debug]pythonLocation=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]Python_ROOT_DIR=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]Python2_ROOT_DIR=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]Python3_ROOT_DIR=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]PKG_CONFIG_PATH=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64/lib/pkgconfig’
##[debug]Set output python-version = 3.12.10
##[debug]Set output python-path = C:\hostedtoolcache\windows\Python\3.12.10\arm64\python.exe
##[debug]Finishing: Set up Python 3.12.10

Comment thread .github/workflows/release_mac.yml Outdated
# Download my patched QtIFW
mkdir QtIFW && cd QtIFW
aria2c https://github.com/jmarrec/QtIFW-fixup/releases/download/v5.0.0-dev-with-fixup/QtIFW-5.0.0-${{ matrix.arch }}.zip
aria2c https://github.com/jmarrec/QtIFW-fixup/releases/download/v5.0.0-dev-with-fixup2/QtIFW-5.0.0-${{ matrix.arch }}.zip

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update patched QtIFW to a newer version: https://github.com/jmarrec/QtIFW-fixup/releases/tag/v5.0.0-dev-with-fixup2

Fix a typo in flags passed to codesign: should be --options not --option

I also updated the target branch onto installer-framework 4.11.0: https://github.com/jmarrec/installer-framework/tree/QTIFW-3084-more-4_11_0

And Updated qt6 static to 6.11.0 (from 6.7.2) since I couldn't build with my macOS 26.5 with clang 21 (and even then, had to cherry pick one Qt commit thart's only on Qt's dev branch...)

jmarrec added 4 commits June 10, 2026 12:32
```
Windows arm64

##[debug]Added matchers: ‘python’. Problem matchers scan action output for known warning or error strings and report these inline.
##[debug]Node Action run completed with exit code 0
##[debug]pythonLocation=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]PKG_CONFIG_PATH=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64/lib/pkgconfig’
##[debug]pythonLocation=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]Python_ROOT_DIR=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]Python2_ROOT_DIR=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]Python3_ROOT_DIR=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64’
##[debug]PKG_CONFIG_PATH=‘C:\hostedtoolcache\windows\Python\3.12.10\arm64/lib/pkgconfig’
##[debug]Set output python-version = 3.12.10
##[debug]Set output python-path = C:\hostedtoolcache\windows\Python\3.12.10\arm64\python.exe
##[debug]Finishing: Set up Python 3.12.10

cmake -G ‘Visual Studio 17 2022’ -A ARM64 -DLINK_WITH_PYTHON:BOOL=ON -DPYTHON_CLI:BOOL=ON -DPython_REQUIRED_VERSION:STRING=3.12.10 ‘-DPython_ROOT_DIR:PATH=C:\hostedtoolcache\windows/Python/3.12.10/arm64/’ -DBUILD_FORTRAN:BOOL=ON -DBUILD_PACKAGE:BOOL=ON -DENABLE_HARDENED_RUNTIME:BOOL=OFF -DDOCUMENTATION_BUILD:STRING=BuildWithAll -DTEX_INTERACTION:STRING=batchmode ../
```

I'm guessing this is the backslash

```

CMake Error at C:/Program Files/CMake/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
  Could NOT find Python (missing: Python_EXECUTABLE Interpreter) (found
  suitable exact version "3.12.10")

      Reason given by package:
          Interpreter: Wrong version for the interpreter "C:/hostedtoolcache/windows/Python/3.13.13/arm64/python.exe"

Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:654 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-4.3/Modules/FindPython/Support.cmake:4334 (find_package_handle_standard_args)
  C:/Program Files/CMake/share/cmake-4.3/Modules/FindPython.cmake:700 (include)
  CMakeLists.txt:190 (find_package)
```
…n cmake 4.3.0) amr64 detection on windows

passing `-DPython_EXECUTABLE:FILEPATH=<...>`bypasses the entire discovery phase, handing CMake a pre-validated path so `_PYTHON_VALIDATE_INTERPRETER` never needs to search

I fixed the issue upstream in cmake but it won't be released soon enough: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/12158
https://github.com/jmarrec/QtIFW-fixup/releases/tag/v5.0.0-dev-with-fixup2

Fix a typo in flags passed to codesign: should be --options not --option, which may explain why the --options runtime wasn't applied to the install .app itself

I also updated the target branch onto installer-framework 4.11.0: https://github.com/jmarrec/installer-framework/tree/QTIFW-3084-more-4_11_0
And Updated qt6 static to 6.11.0 (from 6.7.2) since I couldn't build with my macOS 26.5 with clang 21 (and even then, had to cherry pick one commit...)
@jmarrec jmarrec force-pushed the fixup_windows_arm branch from 946e520 to 591e833 Compare June 10, 2026 10:35

@mitchute mitchute left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like everything is building again. Thanks @jmarrec.

Comment on lines +149 to +155
Python_EXECUTABLE="${{ steps.setup-python.outputs.python-path }}"
Python_EXECUTABLE="${Python_EXECUTABLE//\\//}"
cmake -G "Visual Studio 17 2022" -A ${{ matrix.vs-generator }} \
-DLINK_WITH_PYTHON:BOOL=ON -DPYTHON_CLI:BOOL=ON \
-DPython_REQUIRED_VERSION:STRING=${{ steps.setup-python.outputs.python-version }} \
-DPython_ROOT_DIR:PATH=$RUNNER_TOOL_CACHE/Python/${{ steps.setup-python.outputs.python-version }}/${{ matrix.python-arch }}/ \
-DPython_EXECUTABLE:FILEPATH="$Python_EXECUTABLE" \
-DPython_ROOT_DIR:PATH="$(dirname "$Python_EXECUTABLE")" \

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly pass Python_EXECUTABLE to avoid a broken FindPython (new in cmake 4.3.0) arm64 detection on windows

passing -DPython_EXECUTABLE:FILEPATH=<...>bypasses the entire discovery phase, handing CMake a pre-validated path so _PYTHON_VALIDATE_INTERPRETER never needs to search

I fixed the issue upstream in cmake but it won't be released soon enough: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/12158

(I'm also doing forward slashes now, as I thought it could be the root cause and it's more correct for cmake)

Comment on lines +101 to +103
aria2c https://github.com/jmarrec/QtIFW-fixup/releases/download/v4.11.0-Patched/QtIFW-4.11.0-${{ matrix.arch }}.zip
xattr -r -d com.apple.quarantine ./QtIFW-4.11.0-${{ matrix.arch }}.zip
unzip QtIFW-4.11.0-${{ matrix.arch }}.zip

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the mac failure was actually a fluke to begin with.

But I did go into (a very lenghty) endeavor where I updated my patched qtifw to be based on qtifw 4.11.0, and qt 6.9.1. https://github.com/jmarrec/QtIFW-fixup/releases/tag/v4.11.0-Patched

@mitchute mitchute merged commit eb9a8ed into develop Jun 10, 2026
28 of 33 checks passed
@mitchute mitchute deleted the fixup_windows_arm branch June 10, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest release failed on Windows arm64 and on mac

3 participants