Skip to content

Fix EMS Surface Properties Init - Follow up to #11478#11621

Open
mitchute wants to merge 2 commits into
developfrom
fix-ems-surface-init
Open

Fix EMS Surface Properties Init - Follow up to #11478#11621
mitchute wants to merge 2 commits into
developfrom
fix-ems-surface-init

Conversation

@mitchute
Copy link
Copy Markdown
Collaborator

@mitchute mitchute commented Jun 4, 2026

Pull request overview

  • This is a follow-up to Add EMS actuator for CondFD sky longwave radiation override #11478.
  • Testing after this was merged revealed that there was some minor sensitivity to adjusting the thermal absorptance of a surface material that has the longwave radiation actuator applied. If EMS is being used to override the longwave radiation for a surface that is only facing the sky, we would expect the thermal absorptance in the IDF to not affect the results.
  • This PR moves the EMS surface and construction property inits up in the calling order to they occur before the surfaces are initialized, so the EMS properties get picked up first, when active.

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Jun 4, 2026
@mitchute mitchute requested a review from brianlball June 4, 2026 15:47
Copy link
Copy Markdown
Collaborator Author

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walk through

Comment on lines +2615 to +2618
if (state.dataGlobal->AnyEnergyManagementSystemInModel) {
HeatBalanceSurfaceManager::InitEMSControlledConstructions(state);
HeatBalanceSurfaceManager::InitEMSControlledSurfaceProperties(state);
}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves this up in the calling order so the EMS overrides get picked up before the surfaces are initialized.

! Utility Tariffs: None

Version,26.1;
Version,26.2;
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant to current issue, but these are out of date and it's not worth another PR.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

⚠️ Regressions detected on macos-14 for commit c927605

Regression Summary
  • ERR: 2
  • EIO: 1
  • ESO Big Diffs: 1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit c927605

Regression Summary
  • ERR: 2
  • EIO: 1
  • ESO Big Diffs: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotPublish Includes changes that shouldn't be reported in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants