Skip to content

Remove fmt: convert I* files to std::format (part 4) #11619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchute merged 3 commits into from
Jun 7, 2026
+338 −355
Merged

Remove fmt: convert I* files to std::format (part 4) #11619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8d8c5f
Remove fmt: convert I* files to std::format
brianlball Jun 4, 2026
d01e567
Merge branch 'develop' into remove-fmt-part-4
mitchute Jun 5, 2026
b9c95c1
touchups
mitchute Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 27 additions & 28 deletions src/EnergyPlus/ICEngineElectricGenerator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@

// C++ Headers
#include <cmath>
#include <format>

// ObjexxFCL Headers
#include <ObjexxFCL/Array.functions.hh>
Expand Down Expand Up @@ -104,8 +105,8 @@ namespace ICEngineElectricGenerator {
}
// If we didn't find it, fatal
ShowFatalError(state,
EnergyPlus::format("LocalICEngineGeneratorFactory: Error getting inputs for internal combustion engine generator named: {}",
objectName)); // LCOV_EXCL_LINE
std::format("LocalICEngineGeneratorFactory: Error getting inputs for internal combustion engine generator named: {}",
objectName)); // LCOV_EXCL_LINE
// Shut up the compiler
return nullptr; // LCOV_EXCL_LINE
}
Expand Down Expand Up @@ -138,7 +139,7 @@ namespace ICEngineElectricGenerator {
state.dataInputProcessing->inputProcessor->getNumObjectsFound(state, s_ipsc->cCurrentModuleObject);

if (state.dataICEngElectGen->NumICEngineGenerators <= 0) {
ShowSevereError(state, EnergyPlus::format("No {} equipment specified in input file", s_ipsc->cCurrentModuleObject));
ShowSevereError(state, std::format("No {} equipment specified in input file", s_ipsc->cCurrentModuleObject));
ErrorsFound = true;
}

Expand Down Expand Up @@ -168,8 +169,8 @@ namespace ICEngineElectricGenerator {

iceGen.RatedPowerOutput = NumArray(1);
if (NumArray(1) == 0.0) {
ShowSevereError(state, EnergyPlus::format("Invalid {}={:.2R}", s_ipsc->cNumericFieldNames(1), NumArray(1)));
ShowContinueError(state, EnergyPlus::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ShowSevereError(state, std::format("Invalid {}={:.2f}", s_ipsc->cNumericFieldNames(1), NumArray(1)));
ShowContinueError(state, std::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ErrorsFound = true;
}

Expand Down Expand Up @@ -230,11 +231,10 @@ namespace ICEngineElectricGenerator {
} else {
Real64 xValue = iceGen.ExhaustTempCurve->value(state, 1.0);
if (xValue < ReferenceTemp) {
ShowSevereError(state,
EnergyPlus::format("GetICEngineGeneratorInput: {} output has very low value.", s_ipsc->cAlphaFieldNames(7)));
ShowContinueError(state, EnergyPlus::format("...curve generates [{:.3R} C] at PLR=1.0", xValue));
ShowContinueError(
state, EnergyPlus::format("...this is less than the Reference Temperature [{:.2R} C] and may cause errors.", ReferenceTemp));
ShowSevereError(state, std::format("GetICEngineGeneratorInput: {} output has very low value.", s_ipsc->cAlphaFieldNames(7)));
ShowContinueError(state, std::format("...curve generates [{:.3f} C] at PLR=1.0", xValue));
ShowContinueError(state,
std::format("...this is less than the Reference Temperature [{:.2f} C] and may cause errors.", ReferenceTemp));
}
}

Expand All @@ -257,8 +257,8 @@ namespace ICEngineElectricGenerator {
Node::CompFluidStream::Primary,
Node::ObjectIsNotParent);
if (iceGen.HeatRecInletNodeNum == 0) {
ShowSevereError(state, EnergyPlus::format("Invalid {}={}", s_ipsc->cAlphaFieldNames(8), AlphArray(8)));
ShowContinueError(state, EnergyPlus::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ShowSevereError(state, std::format("Invalid {}={}", s_ipsc->cAlphaFieldNames(8), AlphArray(8)));
ShowContinueError(state, std::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ErrorsFound = true;
}
iceGen.HeatRecOutletNodeNum = Node::GetOnlySingleNode(state,
Expand All @@ -271,8 +271,8 @@ namespace ICEngineElectricGenerator {
Node::CompFluidStream::Primary,
Node::ObjectIsNotParent);
if (iceGen.HeatRecOutletNodeNum == 0) {
ShowSevereError(state, EnergyPlus::format("Invalid {}={}", s_ipsc->cAlphaFieldNames(9), AlphArray(9)));
ShowContinueError(state, EnergyPlus::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ShowSevereError(state, std::format("Invalid {}={}", s_ipsc->cAlphaFieldNames(9), AlphArray(9)));
ShowContinueError(state, std::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ErrorsFound = true;
}
Node::TestCompSet(state, s_ipsc->cCurrentModuleObject, AlphArray(1), AlphArray(8), AlphArray(9), "Heat Recovery Nodes");
Expand All @@ -283,26 +283,26 @@ namespace ICEngineElectricGenerator {
iceGen.HeatRecOutletNodeNum = 0;
if (!s_ipsc->lAlphaFieldBlanks(8) || !s_ipsc->lAlphaFieldBlanks(9)) {
ShowWarningError(state,
EnergyPlus::format("Since Design Heat Flow Rate = 0.0, Heat Recovery inactive for {}={}",
s_ipsc->cCurrentModuleObject,
AlphArray(1)));
std::format("Since Design Heat Flow Rate = 0.0, Heat Recovery inactive for {}={}",
s_ipsc->cCurrentModuleObject,
AlphArray(1)));
ShowContinueError(state, "However, Node names were specified for Heat Recovery inlet or outlet nodes");
}
}

// Validate fuel type input
iceGen.FuelType = static_cast<Constant::eFuel>(getEnumValue(Constant::eFuelNamesUC, AlphArray(10)));
if (iceGen.FuelType == Constant::eFuel::Invalid) {
ShowSevereError(state, EnergyPlus::format("Invalid {}={}", s_ipsc->cAlphaFieldNames(10), AlphArray(10)));
ShowContinueError(state, EnergyPlus::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ShowSevereError(state, std::format("Invalid {}={}", s_ipsc->cAlphaFieldNames(10), AlphArray(10)));
ShowContinueError(state, std::format("Entered in {}={}", s_ipsc->cCurrentModuleObject, AlphArray(1)));
ErrorsFound = true;
}

iceGen.HeatRecMaxTemp = NumArray(11);
}

if (ErrorsFound) {
ShowFatalError(state, EnergyPlus::format("Errors found in processing input for {}", s_ipsc->cCurrentModuleObject));
ShowFatalError(state, std::format("Errors found in processing input for {}", s_ipsc->cCurrentModuleObject));
}
}

Expand All @@ -329,15 +329,15 @@ namespace ICEngineElectricGenerator {
OutputProcessor::EndUseCat::Cogeneration);

SetupOutputVariable(state,
EnergyPlus::format("Generator {} Rate", sFuelType),
std::format("Generator {} Rate", sFuelType),
Constant::Units::W,
this->FuelEnergyUseRate,
OutputProcessor::TimeStepType::System,
OutputProcessor::StoreType::Average,
this->Name);

SetupOutputVariable(state,
EnergyPlus::format("Generator {} Energy", sFuelType),
std::format("Generator {} Energy", sFuelType),
Constant::Units::J,
this->FuelEnergy,
OutputProcessor::TimeStepType::System,
Expand Down Expand Up @@ -365,7 +365,7 @@ namespace ICEngineElectricGenerator {
this->Name);

SetupOutputVariable(state,
EnergyPlus::format("Generator {} Mass Flow Rate", sFuelType),
std::format("Generator {} Mass Flow Rate", sFuelType),
Constant::Units::kg_s,
this->FuelMdot,
OutputProcessor::TimeStepType::System,
Expand Down Expand Up @@ -649,11 +649,10 @@ namespace ICEngineElectricGenerator {
QExhaustRec = max(ExhaustGasFlow * ExhaustCP * (exhaustTemp - exhaustStackTemp), 0.0);
} else {
if (this->ErrExhaustTempIndex == 0) {
ShowWarningMessage(state,
EnergyPlus::format("CalcICEngineGeneratorModel: {}=\"{}\" low Exhaust Temperature from Curve Value",
this->TypeOf,
this->Name));
ShowContinueError(state, EnergyPlus::format("...curve generated temperature=[{:.3R} C], PLR=[{:.3R}].", exhaustTemp, PLR));
ShowWarningMessage(
state,
std::format("CalcICEngineGeneratorModel: {}=\"{}\" low Exhaust Temperature from Curve Value", this->TypeOf, this->Name));
ShowContinueError(state, std::format("...curve generated temperature=[{:.3f} C], PLR=[{:.3f}].", exhaustTemp, PLR));
ShowContinueError(state, "...simulation will continue with exhaust heat reclaim set to 0.");
}
ShowRecurringWarningErrorAtEnd(state,
Expand Down
Loading
Loading