Skip to content

Fix #1978 - Preserve plugin name when unloading net plugin #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theely wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #1978 - Preserve plugin name when unloading net plugin #1979

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0010671
Fix #1978 - Preserve plugin name when unloading net plugin
theely Jan 14, 2026
71091f9
Fix #1978 - Preserve plugin name when unloading net plugin
theely Jan 14, 2026
16f6db1
Merge branch 'fix-1978-net-plugin-reload' of github.com:theely/nccl i…
theely Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/plugin/net.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,12 @@ static ncclResult_t ncclNetPluginUnload(netPluginLib_t* pluginLib) {
if ((pluginLib->dlHandle) && ((pluginLib->ncclNetPluginRefCount) == 0)) {
INFO(NCCL_INIT|NCCL_NET, "Unloading plugin %s", pluginLib->name);
NCCLCHECK(ncclClosePluginLib(pluginLib->dlHandle, ncclPluginTypeNet));
char savedName[sizeof(pluginLib->name)];
strcpy(savedName,pluginLib->name);
// memset will reset the status to ncllNetPluginStateLoadReady
memset(pluginLib, 0, sizeof(netPluginLib_t));
// reset plugin name
strcpy(pluginLib->name, savedName);
// reset the count of devices to UNDEF_DEV_COUNT
pluginLib->netPhysDevs = pluginLib->netVirtDevs = NCCL_UNDEF_DEV_COUNT;
pluginLib->collNetPhysDevs = pluginLib->collNetVirtDevs = NCCL_UNDEF_DEV_COUNT;
Expand Down