Skip to content

feat(machine-controller): factory reset host BMC during tenant release - #5009

Merged
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.1from
spydaNVIDIA:pyda_2.1
Aug 14, 2026
Merged

feat(machine-controller): factory reset host BMC during tenant release#5009
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.1from
spydaNVIDIA:pyda_2.1

Conversation

@spydaNVIDIA

Copy link
Copy Markdown
Contributor

Add a gated, deletion-only FactoryResetBmc sub-state machine to the host platform-config flow so tenant release can proactively clear wedged BMC state (bad/rejected boot order observed on GB200, Grace-Grace, and SMC) before the existing power-cycle / boot-order repair runs.

Related issues

#4759

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

NVIDIA#4944)

Add a gated, deletion-only FactoryResetBmc sub-state machine to the host
platform-config flow so tenant release can proactively clear wedged BMC
state (bad/rejected boot order observed on GB200, Grace-Grace, and SMC)
before the existing power-cycle / boot-order repair runs.

## Related issues
NVIDIA#4759

## Type of Change
- [x] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes
- [ ] **This PR contains breaking changes**

## Testing
- [x] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes
@spydaNVIDIA
spydaNVIDIA requested review from a team and nv-dmendoza August 14, 2026 20:25
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c7154345-10fe-40d6-9e51-0c0fa99fd280

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-08-14 20:28:19 UTC | Commit: 38730ce

@nv-dmendoza nv-dmendoza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes bug

@nv-dmendoza
nv-dmendoza merged commit a622e17 into NVIDIA:release/v2.1 Aug 14, 2026
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants