feat(dpf): Add DPF DPUService create, patch and delete support - #5005
feat(dpf): Add DPF DPUService create, patch and delete support#5005hanyux-nv wants to merge 1 commit into
Conversation
Signed-off-by: Felicity Xu <hanyux@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Summary by CodeRabbit
WalkthroughChangesThe change adds create, JSON merge-patch, and delete operations for detached DPUService lifecycle
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The PR adds DPUService lifecycle operations without any actionable merge-blocking risk remaining; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant DpfOperations
participant DpfSdkOps
participant DpfSdk
participant DpuServiceRepository
participant KubernetesAPI
DpfOperations->>DpfSdkOps: create, patch, or delete DPUService
DpfSdkOps->>DpfSdk: delegate operation
DpfSdk->>DpuServiceRepository: execute namespace-scoped operation
DpuServiceRepository->>KubernetesAPI: apply resource operation
KubernetesAPI-->>DpuServiceRepository: return result or API error
DpuServiceRepository-->>DpfSdk: return operation result
DpfSdk-->>DpfSdkOps: return operation result
DpfSdkOps-->>DpfOperations: return operation result
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
This PR adds
DPUServiceresources.DPUServicelifecycle methods throughDpfSdk.Related issues
#4738
Type of Change
Breaking Changes
Testing