chore(docs): provide clear guidance on DPU configuration for site-controller nodes#3048
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThis change updates the site controller DPU requirements in the quick-start and hardware prerequisite docs. It now makes BlueField-3 DPUs mandatory, restricts operation to DPU mode, and pins the firmware, optics, connectivity, and download details. ChangesSite controller DPU requirements docs
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Container Scan SummaryNo Grype artifacts were found to aggregate. |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-3048.docs.buildwithfern.com/infra-controller |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/getting-started/prerequisites/hardware.md`:
- Line 31: The connectivity example in the hardware prerequisites doc uses curl
with -k, which bypasses TLS verification; update the example in the connectivity
check to use plain curl so it actually validates the trust path. Keep the
guidance aligned with the surrounding prerequisites content and adjust the
example text in the relevant markdown section so it remains realistic and safe
for operators.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3db2954a-cf23-41db-8c23-3f7f286a687e
📒 Files selected for processing (2)
docs/getting-started/prerequisites/hardware.mddocs/getting-started/quick-start.md
✅ Files skipped from review due to trivial changes (1)
- docs/getting-started/quick-start.md
polarweasel
left a comment
There was a problem hiding this comment.
Minor stuff, including arguing with Coderabbit 😁
chore(docs): provide clear guidance on DPU configuration for site-controller nodes
Related issues
#2992
Type of Change
Breaking Changes
Testing
Additional Notes