Skip to content

docs: Add REST endpoint guidance#3031

Draft
kfelternv wants to merge 2 commits into
NVIDIA:mainfrom
kfelternv:agents-rest-api-guidance
Draft

docs: Add REST endpoint guidance#3031
kfelternv wants to merge 2 commits into
NVIDIA:mainfrom
kfelternv:agents-rest-api-guidance

Conversation

@kfelternv

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a276fd02-f064-4bd4-ba02-2f29f109f85d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@thossain-nv

Copy link
Copy Markdown
Contributor

This is great @kfelternv A few other things to add:

  • FromDBModel (we want to transition from NewX to this receiver) and ToDBModel for converting between APi and DB models
  • All API model attributes should be structured, we don't allow schemaless JSON exposure. JSON tags must be camel Case. All constants should be in Pascal Case.
  • Implementor should seek observe all existing endpoint routes to make the best decision for a new route. Naming the route and attributes correctly is critical, once published in a release tag it must use deprecation to In general we follow REST best practices:
    • Creating new objects should be done using POST
    • Updates should be done using PATCH
    • PUT is used only if the endpoint supports both creation or update
    • Unless the resource has no unique identifier, PATCH, GET and DELETE routes must end with resource ID
    • GET requests that return multiple objects must return pagination information in designated pagination header in response

…-3031

Signed-off-by: Kyle Felter <kfelternv@users.noreply.github.com>

# Conflicts:
#	rest-api/AGENTS.md

Co-authored-by: Kyle Felter <kfelternv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants