Fix intermittent ThreadLeak failures in the concurrent IT tests - #2499
Draft
imotov wants to merge 1 commit into
Draft
Fix intermittent ThreadLeak failures in the concurrent IT tests#2499imotov wants to merge 1 commit into
imotov wants to merge 1 commit into
Conversation
`awaitTermination()` returns once the pool reaches TERMINATED, which happens before the workers finish `processWorkerExit()`, so the threads are still alive and `ThreadLeakLingering` defaults to no wait, leaving `RandomizedRunner` to report dying threads as leaks. Annotate `CuVSTestCase` with `@ThreadLeakLingering(linger = 5000)`, inherited by all four IT classes that create executors. Also make `runConcurrently` shut the pool down on every path rather than only on success, bound the wait at 60 seconds, keep the pooled-memory reset unconditional, and report a failing task by catching `ExecutionException` instead of throwing from `exceptionally()`.
imotov
added
bug
Contributor
Author
|
/ok to test 9c5c2fe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
awaitTermination()returns once the pool reaches TERMINATED, which happens before the workers finishprocessWorkerExit(), so the threads are still alive andThreadLeakLingeringdefaults to no wait, leavingRandomizedRunnerto report dying threads as leaks. AnnotateCuVSTestCasewith@ThreadLeakLingering(linger = 5000), inherited by all four IT classes that create executors. Also makerunConcurrentlyshut the pool down on every path rather than only on success, bound the wait at 60 seconds, keep the pooled-memory reset unconditional, and report a failing task by catchingExecutionExceptioninstead of throwing fromexceptionally().Fixes #2498