Attempt to fix publishing#4436
Open
mitchdz wants to merge 3 commits intoNVIDIA:mainfrom
Open
Conversation
Signed-off-by: mdzurick <mitch_dz@hotmail.com>
test_cupy_to_state_ownership_semantics was added in NVIDIA#4327 to lock in the contract that from_data aliases a contiguous CuPy device buffer. The test fails: reading the State after mutating the CuPy source returns the original value, not the mutation. Aliasing itself works. The bug is on the read side. CusvState:: extractValues issues a synchronous cudaMemcpy(D2H) from devicePtr. With per-thread default streams (modern CUDA + recent CuPy), a synchronous cudaMemcpy does not wait for work on other streams. CuPy's __setitem__ runs on its own stream, our memcpy on the default stream, and the read can race past the write. Add cudaDeviceSynchronize() before the memcpy in extractValues. This is the single choke point all host-side reads flow through (toHost, getAmplitude, operator()), so one line covers them. dump() has the same pattern but isn't exercised by the test; leaving it for now. Signed-off-by: mdzurick <mitch_dz@hotmail.com>
Signed-off-by: mdzurick <mitch_dz@hotmail.com>
CI Summary — ✅ passedRun #25233730135 · trigger Top-level jobs (13)
⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch
All sub-jobs (50) — every matrix leg, with links
✅ Required checks (8/8) — declared in
|
| Required check | Status | Link |
|---|---|---|
| Build and test (amd64, clang16, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, clang16, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, gcc11, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, gcc11, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (arm64, clang16, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (arm64, clang16, openmpi) / Dev environment (Python) | ✅ success | view |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.