[sample] [C++] Updated kernels to not have user-specified measurement ops #3624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalatepradnya
force-pushed
the
update-sampling-api
branch
from
4f962e6 to
eeacd68
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
no explicit measurement operation allowed. For simulators, issue a warning. Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
update-sampling-api
branch
2 times, most recently
from
18945eb to
0bc83e7
Compare
khalatepradnya
commented
Dec 12, 2025
Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
update-sampling-api
branch
2 times, most recently
from
20b9805 to
f7490d3
Compare
Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
update-sampling-api
branch
from
f7490d3 to
f6b078d
Compare
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
update-sampling-api
branch
from
3a972d2 to
8cbf721
Compare
Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
update-sampling-api
branch
from
8cbf721 to
0208633
Compare
* No checking of measurement operations in this PR Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors several C++ example and application files using
sampleAPI by removing explicit measurement instructions (mz(...)/my(...)/mx(...)) from quantum kernels and instead extracting measurement results using marginalization (get_marginal) or direct return values (run).This demonstrates best practices for using
sampleas we introduce scoping changes.Removed explicit measurement operations from quantum kernels in multiple files (e.g.,
bernstein_vazirani.cpp,grover.cpp,ghzexamples, and noise modeling examples), relying on default measurement behavior or returning measurement results directly.Updated main functions to extract and analyze measurement results using
get_marginalor by usingrun, ensuring only relevant qubits are considered in the analysis.Improved examples to show best practices for extracting and displaying measurement statistics.
Identified examples with mid-circuit measurements that cannot (yet) be converted to
runto emitqir-adaptive(Work on simulators)