test(cuda.core): cover PDL same-stream overlap via GraphBuilder capture - #2524
Open
lijinf2 wants to merge 11 commits into
Open
test(cuda.core): cover PDL same-stream overlap via GraphBuilder capture#2524lijinf2 wants to merge 11 commits into
lijinf2 wants to merge 11 commits into
Conversation
Cover GraphBuilder stream-capture for programmatic_stream_serialization: functional launch, programmatic dependency edge mapping, and Hopper+ overlap (xfail if opportunistic), plus 1.2.0 release notes.
Refer to cudaLaunchAttributeProgrammaticStreamSerialization instead of the driver-style CU_LAUNCH_ATTRIBUTE_* spelling.
Contributor
lijinf2
marked this pull request as draft
August 6, 2026 19:50
lijinf2
changed the title
lijinf2
added
cuda.core
lijinf2
force-pushed
the
fea/1334-pdl-launch-config-graph
branch
from
August 6, 2026 20:01
7ebea54 to
4ca415b
Compare
Contributor
Author
|
/ok to test 4ca415b |
lijinf2
changed the title
The test writes host buffers from np.from_dlpack, which are read-only before NumPy 2.2.5 (GH #28632).
Align with other graph builder tests so context setup and teardown stay consistent.
Drop fragile Programming Guide section numbers and note Driver vs Runtime enum name equivalence at the edge asserts.
Extract kernels and the same-stream / graph-capture overlap check into run_pdl_overlap_check so launcher and GraphBuilder tests stay in sync.
Both direct and graph-capture paths are same-stream; update names and docs accordingly.
lijinf2
changed the title
lijinf2
marked this pull request as ready for review
August 7, 2026 18:58
Contributor
Author
|
/ok to test fdfdf8b |
|
isVoid
reviewed
Aug 13, 2026
| return mod.get_kernel("primary_kernel"), mod.get_kernel("secondary_kernel") | ||
|
|
||
|
|
||
| def run_pdl_overlap_check(device, *, via_graph: bool = False): |
Contributor
There was a problem hiding this comment.
Why do we need to test with graph launch? This seems like an additional requirement for programmatic stream.
Contributor
Author
There was a problem hiding this comment.
Yeah, that is a request in #1334
per "PDL launches are graph-compatible and this use case should be tested and showcased"
isVoid
reviewed
Aug 13, 2026
Comment on lines
+734
to
+736
| mod = compile_common_kernels() | ||
| producer = mod.get_kernel("add_one") | ||
| consumer = mod.get_kernel("add_one") |
Contributor
There was a problem hiding this comment.
So... I'm curious. add_one is a simple kernel that doesn't have programmatic dependency like the kernel primary_kernel. Setting programmatic_stream_serialization between for the second launch still create a graph dependency between these two kernels?
Contributor
Author
There was a problem hiding this comment.
Yeah, here just needs two dummy kernels as input so that we can check things in _assert_programmatic_dependency_edge.
Renamed to dummy_kernel.
lijinf2
force-pushed
the
fea/1334-pdl-launch-config-graph
branch
from
August 13, 2026 20:43
fdfdf8b to
2e0d2e6
Compare
…tests Keep the stream overlap case self-contained in test_launcher, and inline the graph capture/overlap checks in test_graph_builder so each path stays simple.
Avoid implying an in-kernel producer/consumer dependency; the test only needs two launches for the programmatic edge assert.
Contributor
Author
|
/ok to test 8f922e6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #1334
programmatic_stream_serialization: programmatic dependency-edge mapping and same-stream primary/secondary overlap (Hopper+, opportunistic → xfail).helpers/pdl_kernels.pyso direct and graph-capture paths stay in sync.Checklist