-
Notifications
You must be signed in to change notification settings - Fork 320
ci: constrain internal builds to exact local wheels #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+217
−39
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we explicitly want to test cuda-core against the already-published cuda-bindings to make sure we don't break backward compat. Does this remove that kind of testing (in favor of testing with latest)? I think ideally we need to do both.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I asked codex to carefully inspect the CI code. The answer is:
No, this PR does not remove that compatibility testing.
Agreed. That is already what our CI is meant to do. This PR makes the current-build side reliable without changing the published-wheel compatibility side.
This repository already explicitly implements both:
cuda-bindingsused with currentcuda-corenightly-cuda-corecuda-corewith main-builtcuda-pathfinderandcuda-bindingsAt a high level, the build and test stages have deliberately different policies:
BINDINGS_SOURCEselects which bindings wheel to install:For example, the current build version is CUDA 13.3, while the PR test matrix contains many CUDA 13.0.2 rows. Those rows install
cuda-bindings==13.0.*from PyPI, then install the core wheel built by the current CI run and run the core tests. Thus the matrix exercises both current bindings and already-published bindings.Evidence for published-wheel compatibility coverage
ci/tools/env-varsexplicitly definespublishedas installing from PyPI. For a same-major/minor-mismatch it selects that mode "to test the real-world backward-compat scenario."ci/tools/run-testsimplements the policy: inpublishedmode it installscuda-bindings==${TEST_CUDA_MAJOR}.${TEST_CUDA_MINOR}.*, then installs the current-run core wheel and runs its tests.ci/versions.ymland the CUDA 13.0.2 entries inci/test-matrix.ymlensure that this mode is exercised while the current build CUDA version is 13.3.ci/test-matrix.ymlandci/tools/run-tests).Evidence for current-run/local-wheel coverage
ci/tools/env-varslogic says that an exact CUDA major/minor match uses "the just-built bindings wheel."mainmode the bindings artifact, from the applicable CI run and pass those wheel paths directly to pip.PIP_FIND_LINKSsettings already indicated that the newly built local wheels were intended to feed downstream builds. The weakness was thatPIP_FIND_LINKSonly added candidates; it did not guarantee that pip selected them over PyPI.cuda-bindings[all]==13.*, so a published 13.0 bindings wheel still satisfies it.The PR changes only the build-wheel, coverage, and sdist-build workflows. It does not change
ci/tools/env-vars,ci/tools/run-tests, the test matrix, or the test-wheel workflows that implement the published-wheel compatibility coverage.One distinction worth calling out: the existing compatibility lane builds the core wheel with the current-run bindings, then installs and tests that wheel with an older published bindings version. It does not separately build/cythonize core against the older binding. If that second build-time scenario is what you meant, it would be additional coverage rather than something this PR removes; the previous unconstrained resolver behavior did not select an older release systematically enough to provide such coverage.