Skip to content

Conversation

@yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Nov 18, 2025

Description

Update ci tests for prompt_embedding_table_data_type input.

Test Coverage

L0_backend_trtllm--base

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Bug Fixes
    • Improved cleanup procedures during engine generation to remove stale artifacts and ensure fresh builds.
    • Enhanced tokenizer cleanup during build process.
    • Updated model configuration with optimized embedding table data type settings for better compatibility.

@yinggeh yinggeh requested a review from a team as a code owner November 18, 2025 23:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

📝 Walkthrough

Walkthrough

Two CI scripts are updated with copyright year increments and operational improvements. The generate_engines.sh script adds cleanup operations that remove and recreate directories before populating them. The test.sh script introduces a new configuration parameter for model tensor data types.

Changes

Cohort / File(s) Summary
Copyright year and script enhancements
triton_backend/ci/L0_backend_trtllm/generate_engines.sh
Updated copyright from 2024 to 2025. Added cleanup steps that replace mkdir with rm -rf <dir> && mkdir <dir> for engines and tokenizer directories before file operations.
Configuration and copyright updates
triton_backend/ci/L0_backend_trtllm/test.sh
Updated copyright from 2024 to 2024-2025. Added prompt_embedding_table_data_type:TYPE_FP16 configuration to two tensorrt_llm model configs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Straightforward copyright year updates across both files (minimal impact)
  • Directory cleanup logic in generate_engines.sh follows a consistent, simple pattern
  • Configuration parameter additions in test.sh are isolated, localized changes to model configs

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'Fix L0_backend_trtllm' but lacks specificity about what is being fixed. The changes involve updating copyright years, adding cleanup steps in generate_engines.sh, and adding prompt_embedding_table_data_type configuration to test.sh. The title is too vague to clearly convey the primary changes. Provide a more specific title that captures the main changes, such as 'Update L0_backend_trtllm for prompt_embedding_table_data_type support' or 'Add cleanup steps and config updates to L0_backend_trtllm tests'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required sections (Description, Test Coverage) and the PR Checklist is completed with confirmation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yinggeh yinggeh changed the title [TRI-332] Fix L0_backend_trtllm [TRI-332] [fix] Fix L0_backend_trtllm Nov 18, 2025
@Tabrizian
Copy link
Member

/bot run --disable-fail-fast

@Tabrizian Tabrizian enabled auto-merge (squash) November 19, 2025 07:54
@tensorrt-cicd
Copy link
Collaborator

PR_Github #25015 [ run ] triggered by Bot. Commit: b105159

@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Nov 19, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #25015 [ run ] completed with state SUCCESS. Commit: b105159
/LLM/main/L0_MergeRequest_PR pipeline #18899 completed with status: 'SUCCESS'

@yinggeh
Copy link
Contributor Author

yinggeh commented Nov 20, 2025

@Tabrizian Can we merge?

@pcastonguay
Copy link
Collaborator

@Tabrizian Can we merge?

The DCO check is failing since the commits are not signed. Would it be possible to update with signed commits? Thanks.

auto-merge was automatically disabled November 20, 2025 16:55

Head branch was pushed to by a user without write access

@Tabrizian
Copy link
Member

@yinggeh All the commits need to be signed. Looks like they are still not signed.

Signed-off-by: Yingge He <[email protected]>
@yinggeh yinggeh force-pushed the yinggeh/tri-332-2511-l0_backend_trtllm-base branch from a67a9d6 to 5bc12d7 Compare November 20, 2025 19:06
@yinggeh
Copy link
Contributor Author

yinggeh commented Nov 20, 2025

@yinggeh All the commits need to be signed. Looks like they are still not signed.

Signed

@pcastonguay
Copy link
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25241 [ run ] triggered by Bot. Commit: 5bc12d7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25241 [ run ] completed with state SUCCESS. Commit: 5bc12d7
/LLM/main/L0_MergeRequest_PR pipeline #19090 completed with status: 'SUCCESS'

@Tabrizian Tabrizian merged commit b5863ed into NVIDIA:main Nov 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community want to contribute PRs initiated from Community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants