Skip to content

[TRTLLM-9295][test] enable FlashInfer.sampling by default (DO NOT MERGE) #9270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[TRTLLM-9295][test] enable FlashInfer.sampling by default (DO NOT MERGE) #9270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
896842f
test: enable FlashInfer.sampling by default
ixlmar Nov 13, 2025
e0636bd
fix: use greedy decoding in test_openai_compatible_json_schema
ixlmar Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorrt_llm/llmapi/llm_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2765,7 +2765,7 @@ class TorchLlmArgs(BaseLlmArgs):
# PrivateVars
_quant_config: Optional[QuantConfig] = PrivateAttr(default=None)

_disable_flash_infer_sampling: bool = PrivateAttr(default=True)
_disable_flash_infer_sampling: bool = PrivateAttr(default=False)
"""Unless this is set to False, FlashInfer.sampling is not used, even if available."""

@property
Expand Down
1 change: 1 addition & 0 deletions tests/unittest/llmapi/apps/_test_openai_chat_guided_decoding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def test_openai_compatible_json_schema(client: openai.OpenAI, model_name: str):
"type": "json_schema",
"json_schema": json_schema
},
temperature=0.0,
)

message = chat_completion.choices[0].message
Expand Down
Loading