Skip to content

Conversation

byshiue
Copy link
Collaborator

@byshiue byshiue commented Oct 3, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled previously skipped performance latency tests for a large-model configuration across multiple backends, improving test coverage and CI confidence.
    • Removed legacy waivers to ensure these scenarios are now validated in routine runs.
    • No changes to user-facing functionality; this update strengthens reliability of performance verification and accelerates feedback during releases.

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 3, 2025

/bot -h

Copy link

github-actions bot commented Oct 3, 2025

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 3, 2025

/bot run --only-multi-gpu-test

Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

📝 Walkthrough

Walkthrough

Removed two SKIP entries from the integration test waives list for Qwen3_235B_A22B latency MoE tests (nvfp4 trtllm and nvfp4 cutlass). No other files or logic were modified.

Changes

Cohort / File(s) Summary of Changes
Test waiver list updates
tests/integration/test_lists/waives.txt
Deleted two SKIP entries for TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm] and TestQwen3_235B_A22B::test_nvfp4[latency_moe_cutlass].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning There is no pull request description provided, but the repository requires a structured template including a summary, description, test coverage, and checklist sections. Please add a pull request description following the repository template by including an @coderabbitai summary, a brief description of the changes and rationale, relevant test coverage details, and the completed PR checklist sections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “[https://nvbugs/5516666][fix] unwaive some Qwen3 CI tests” succinctly follows the project’s ticket and type convention and accurately describes the primary change of removing skips on Qwen3 latency MoE tests.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba3dbb6 and 4d5dc28.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20571 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20571 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15526 (Partly Tested) completed with status: 'FAILURE'

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 3, 2025

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20581 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20581 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15535 (Partly Tested) completed with status: 'FAILURE'

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 3, 2025

/bot run --post-merge --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20591 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20591 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15544 completed with status: 'FAILURE'

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 3, 2025

/bot skip --comment "The tests of Qwen3 multi-nodes GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-6 and GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-7 pass"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20619 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20619 [ skip ] completed with state SUCCESS
Skipping testing for commit 4d5dc28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants