feat(vm): add vm life cycle extensions#1583
Open
cheese-head wants to merge 1 commit into
Open
Conversation
Signed-off-by: Patrick Riel <priel@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds lifecycle extension points to the VM driver so future integrations can inspect and adjust VM launch plans around sandbox startup and cleanup. The default registry is empty, so existing VM sandbox behavior remains unchanged.
Related Issue
Not linked
Changes
Testing
mise run pre-commitpasses (not run;miseis not available in this shell)Additional validation run:
cargo fmt -p openshell-driver-vmcargo test -p openshell-driver-vm lifecycle -- --nocapturecargo test -p openshell-driver-vm qemu -- --nocapturecargo clippy -p openshell-driver-vm --all-targets -- -D warningscargo test -p openshell-driver-vmgit diff --checkChecklist