Skip to content

fix(build): install binaries built in part build tree#1462

Merged
pimlock merged 1 commit into
NVIDIA:mainfrom
zyga:fix/snap
May 19, 2026
Merged

fix(build): install binaries built in part build tree#1462
pimlock merged 1 commit into
NVIDIA:mainfrom
zyga:fix/snap

Conversation

@zyga
Copy link
Copy Markdown
Contributor

@zyga zyga commented May 19, 2026

Summary

Fixes the snap build from a pristine tree

Related Issue

N/A

Changes

The snapcraft built recipe now installs binaries that were built in the part instead of those that came with the workspace tree on the host.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

The earlier build only worked if the tree had pre-compiled binaries left
over from non-snap build.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@zyga zyga requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 19, 2026 21:27
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pimlock
Copy link
Copy Markdown
Collaborator

pimlock commented May 19, 2026

/ok to test bf50611

@pimlock pimlock merged commit 0a8b35c into NVIDIA:main May 19, 2026
27 checks passed
@zyga zyga deleted the fix/snap branch May 19, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants