Skip to content

refactor(driver): trim compute capability response#1402

Open
elezar wants to merge 1 commit into
mainfrom
cleanup-driver-capabilities-en
Open

refactor(driver): trim compute capability response#1402
elezar wants to merge 1 commit into
mainfrom
cleanup-driver-capabilities-en

Conversation

@elezar
Copy link
Copy Markdown
Member

@elezar elezar commented May 15, 2026

Summary

Remove unused GPU availability fields from the internal compute driver capability response. GPU admission remains driver-local and is still validated when a sandbox create request asks for GPU resources.

Related Issue

None.

Changes

  • Reserved the removed compute-driver capability proto fields and names.
  • Stopped populating GPU capability fields from Docker, Kubernetes, Podman, VM, and test drivers.
  • Documented that the capability RPC reports driver identity, version, and default image only.
  • Addressed clippy fallout from the now-sync Kubernetes capability path.

Testing

  • cargo check -p openshell-core -p openshell-driver-docker -p openshell-driver-kubernetes -p openshell-driver-podman -p openshell-driver-vm -p openshell-server
  • cargo test -p openshell-server -p openshell-driver-docker -p openshell-driver-kubernetes -p openshell-driver-podman -p openshell-driver-vm --no-run
  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 15, 2026 15:02
Comment on lines +48 to +49
reserved 4, 5;
reserved "supports_gpu", "gpu_count";
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drew would a breaking API change (simply removing the fields) be better in this case. I think we can add additional information as part of the resource requirement changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant