fix(cli): use OS trust store for reqwest TLS verification#1342
Merged
Conversation
sjenning
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
|
Label |
Collaborator
|
/ok to test a5e74b8 |
sjenning
force-pushed
the
fix/reqwest-native-roots
branch
from
a5e74b8 to
2874e51
Compare
Collaborator
|
/ok to test 2874e51 |
Switch reqwest from `rustls-tls` (bundled Mozilla webpki roots) to `rustls-tls-native-roots` (OS certificate store) so that the CLI trusts the same CAs as the rest of the system. This fixes OIDC discovery failures against Keycloak instances using certificates signed by internal CAs present in the system trust bundle.
sjenning
force-pushed
the
fix/reqwest-native-roots
branch
from
2874e51 to
6f5084f
Compare
Collaborator
|
/ok to test 6f5084f |
TaylorMutch
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustls-tls(bundled Mozilla webpki roots) torustls-tls-native-roots(OS certificate store) so the CLI trusts the same CAs as the rest of the systemUnknownIssuer) against Keycloak instances using certificates signed by internal CAs present in the system trust bundletokio-tungstenite, which already usesrustls-tls-native-rootsTest plan
openshell gateway loginagainst a Keycloak instance with an internally-signed certificateUnknownIssuererror