Skip to content

fix(installer): guard incompatible v0.0.37 upgrades#1294

Merged
drew merged 3 commits intomainfrom
chore/update-mise-lockfile/anewberry
May 9, 2026
Merged

fix(installer): guard incompatible v0.0.37 upgrades#1294
drew merged 3 commits intomainfrom
chore/update-mise-lockfile/anewberry

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 9, 2026

Summary

Add an installer guard for users upgrading from OpenShell v0.0.36 or earlier to v0.0.37 and later.

Related Issue

Fixes #1293

Changes

  • Detect an existing openshell binary before package replacement starts.
  • Parse the installed version and only warn/block when installing v0.0.37+ or dev over a pre-v0.0.37 installation.
  • Print the required upgrade guide: back up sandbox files and artifacts, run openshell sandbox delete --all, run openshell gateway destroy, then rerun the installer or follow the published installation guide.
  • Require OPENSHELL_ACK_BREAKING_UPGRADE=1 to continue after the user has already completed the cleanup.

Testing

  • sh -n install.sh
  • shellcheck install.sh
  • Semver helper dry run for 0.0.36, 0.0.37-dev.156+g..., and v0.0.38
  • Fake openshell 0.0.36 dry run prints the upgrade guide and exits before package installation
  • mise run pre-commit passes

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 9, 2026 17:32
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew force-pushed the chore/update-mise-lockfile/anewberry branch from f233f6f to 09ec2e7 Compare May 9, 2026 17:33
TaylorMutch
TaylorMutch previously approved these changes May 9, 2026
maxamillion
maxamillion previously approved these changes May 9, 2026
@drew drew changed the title chore(mise): update lockfile fix(installer): guard incompatible v0.0.37 upgrades May 9, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew dismissed stale reviews from maxamillion and TaylorMutch via b28d8de May 9, 2026 17:44
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew merged commit 072f227 into main May 9, 2026
22 checks passed
@drew drew deleted the chore/update-mise-lockfile/anewberry branch May 9, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cli): openshell gateway start removed in v0.0.37 with no migration guide — "unrecognized subcommand 'start'"

3 participants