feat: hook mediator daemon into sandbox entrypoint#1586
Draft
zaristei wants to merge 1 commit intoNVIDIA:mainfrom
Draft
feat: hook mediator daemon into sandbox entrypoint#1586zaristei wants to merge 1 commit intoNVIDIA:mainfrom
zaristei wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Adds start_mediator_daemon() to nemoclaw-start.sh. If /sandbox/mediator-daemon exists, starts it before the gateway. Exports MEDIATOR_SOCKET and MEDIATOR_TOKEN to env + bashrc/profile. Backward compatible — skips if binary absent. Hooked into both root and non-root entrypoint paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds mediator daemon startup to
nemoclaw-start.sh. If/sandbox/mediator-daemonexists in the container, the entrypoint starts it as a background process before the gateway, exportsMEDIATOR_SOCKETandMEDIATOR_TOKENto the sandbox user's environment.This is the NemoClaw-side integration for the mediator policy engine built in OpenShell. The mediator enables per-process resource isolation inside the sandbox — the agent proposes scoped policies at runtime instead of the operator widening the entire sandbox's permissions.
Design doc: mediator-design-principles.md
Changes
start_mediator_daemon()function innemoclaw-start.sh/sandbox/mediator-daemonif present, waits for socket, exports env varsMEDIATOR_SOCKETandMEDIATOR_TOKENto.bashrcand.profilefor interactive sessionsTest plan
mediator-cli psandpolicy_listwork from sandbox shell🤖 Generated with Claude Code