Refactor package naming: move from flavor-based names to version-based dev differentiation #6107
Conversation
Greptile OverviewGreptile SummaryRefactored DALI package naming from flavor-based suffixes to unified naming with version-based differentiation using PEP 440 dev releases.
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Build as Build System
participant CMake as CMake
participant Setup as setup.py
participant PyPI as PyPI/Index
participant User as End User
Note over Build,CMake: Build Configuration Phase
Build->>CMake: Set DALI_BUILD_FLAVOR (e.g., "nightly")
Build->>CMake: Set TIMESTAMP (e.g., "20250104")
CMake->>CMake: Read VERSION file (e.g., "1.53.0dev")
alt Development Build (DALI_BUILD_FLAVOR set)
CMake->>CMake: Validate VERSION contains "dev"
CMake->>CMake: Append TIMESTAMP: "1.53.0dev20250104"
else Stable Build
CMake->>CMake: Keep VERSION as-is: "1.53.0"
end
Note over CMake,Setup: Package Configuration Phase
CMake->>Setup: Configure setup.py with unified name
Note right of Setup: OLD: nvidia-dali-nightly-cuda120<br/>NEW: nvidia-dali-cuda120
Setup->>Setup: Set version to "1.53.0dev20250104"
Note over Setup,PyPI: Publishing Phase
Setup->>PyPI: Publish package
Note right of PyPI: Package: nvidia-dali-cuda120<br/>Version: 1.53.0dev20250104<br/>PEP 440 dev release
Note over User,PyPI: Installation Phase
User->>PyPI: pip install --pre nvidia-dali-cuda120
PyPI->>User: Return dev version (1.53.0dev20250104)
User->>PyPI: pip install nvidia-dali-cuda120
PyPI->>User: Return stable version only (1.53.0)
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments (4)
-
docs/installation.rst, line 145-146 (link)logic: package names in documentation still reference old flavor-based naming (
nvidia-dali-nightly-cuda120,nvidia-dali-tf-plugin-nightly-cuda120), should be updated to new unified naming (nvidia-dali-cuda120,nvidia-dali-tf-plugin-cuda120) -
docs/installation.rst, line 152-153 (link)logic: package names in documentation still reference old flavor-based naming (
nvidia-dali-nightly-cuda130,nvidia-dali-tf-plugin-nightly-cuda130), should be updated to new unified naming (nvidia-dali-cuda130,nvidia-dali-tf-plugin-cuda130) -
docs/installation.rst, line 164-165 (link)logic: package names in documentation still reference old flavor-based naming (
nvidia-dali-weekly-cuda130,nvidia-dali-tf-plugin-weekly-cuda130), should be updated to new unified naming (nvidia-dali-cuda130,nvidia-dali-tf-plugin-cuda130) -
docs/compilation.rst, line 72-73 (link)logic: documentation mentions old naming convention where
DALI_BUILD_FLAVORadds suffix to package name (e.g.,nvidia-dali-nightly), but this has changed to version-based differentiation
6 files reviewed, 4 comments
JanuszL
force-pushed
the
new_dev_naming_schema
branch
2 times, most recently
from
3e1fa28 to
2a28fbe
Compare
|
!build |
|
CI MESSAGE: [39593786]: BUILD STARTED |
docs/installation.rst
Outdated
|
|
||
| It is recommended to uninstall regular DALI and TensorFlow plugin before installing nightly or weekly | ||
| builds as they are installed in the same path | ||
| **New distribution method (starting from version 2.0):** Nightly and weekly builds now use the same |
There was a problem hiding this comment.
logic: Version mismatch: documentation states "starting from version 2.0" but the current VERSION file shows 1.53.0dev. Should this say "starting from version 1.53" instead?
| **New distribution method (starting from version 2.0):** Nightly and weekly builds now use the same | |
| **New distribution method (starting from version 1.53):** Nightly and weekly builds now use the same |
There was a problem hiding this comment.
I should be fixed now.
JanuszL
force-pushed
the
new_dev_naming_schema
branch
from
2a28fbe to
2daff9a
Compare
There was a problem hiding this comment.
Additional Comments (1)
-
docs/compilation.rst, line 72-73 (link)style: Outdated documentation - still references old package naming (e.g.,
nvidia-dali-nightly). Should be updated to reflect new unified naming where flavor no longer affects package name, only version suffix.
7 files reviewed, 1 comment
…d dev differentiation
- Previously, weekly/nightly builds were differentiated by flavor suffix in the
package name (e.g., nvidia-dali-weekly-cuda*, nvidia-dali-nightly-cuda*).
This change moves to a unified naming schema where:
- Package names are consistent regardless of build type (nvidia-dali-cuda*)
- Dev builds are differentiated by .dev{TIMESTAMP} suffix in version number
- Stable and dev packages share the same package name, distinguished only by version
- Removes DALI_FLAVOR_MINUS variable from CMakeLists.txt files
- Updates package names to remove flavor suffix:
- nvidia-dali-cuda* (was nvidia-dali-{flavor}-cuda*)
- nvidia-dali-tf-plugin-cuda* (was nvidia-dali-tf-plugin-{flavor}-cuda*)
- nvidia-dali-{plugin} (was nvidia-dali-{plugin}-{flavor})
- Standardizes dev version format: use .dev{TIMESTAMP} instead of .{TIMESTAMP}
- Updates install_requires in TF plugin to match new naming schema
- Updates installation documentation to explain new distribution method:
- Documents new unified package naming with .dev{TIMESTAMP} version suffix
- Explains use of --pre flag for installing dev builds
- Adds legacy distribution section for pre-1.53 builds
- Clarifies nightly vs weekly build schedule and availability
Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
new_dev_naming_schema
branch
from
2daff9a to
2bf93ca
Compare
|
!build |
|
CI MESSAGE: [39597446]: BUILD STARTED |
|
CI MESSAGE: [39593786]: BUILD PASSED |
|
CI MESSAGE: [39597446]: BUILD PASSED |
2 participants
package name (e.g., nvidia-dali-weekly-cuda*, nvidia-dali-nightly-cuda*).
This change moves to a unified naming schema where:
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
package name (e.g., nvidia-dali-weekly-cuda*, nvidia-dali-nightly-cuda*).
This change moves to a unified naming schema where:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A