fix: avoid mutable default argument in ExactStringPerCategoryMatchMetric - #15953
Closed
andrewwhitecdw wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Andrew White <andrewh@cdw.com>
Author
|
Could a maintainer please add the |
Member
|
These are all blind AI generated PRs. Why do we need a test case to test None as default? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the mutable default argument
categories=[]withcategories=Noneand instantiates a fresh list inside the constructor. This prevents shared state across metric instances.nemo/collections/common/metrics/classification_accuracy.py: changed default and added None guardtests/collections/common/test_metrics.pyTested:
uv run python -m pytest tests/collections/common/test_metrics.py::TestCommonMetrics::test_exact_string_per_category_match_metric_default_categories_is_none tests/collections/common/test_metrics.py::TestCommonMetrics::test_exact_string_per_category_match_metric_tracks_categories -v # 2 passedcc @nithinraok for common/core review