Skip to content

fix(ci): AUT-1100 keep verl and MCore on main - #5119

Open
svcnemo-autobot wants to merge 11 commits into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/pin-verl-e2e-ref
Open

fix(ci): AUT-1100 keep verl and MCore on main#5119
svcnemo-autobot wants to merge 11 commits into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/pin-verl-e2e-ref

Conversation

@svcnemo-autobot

@svcnemo-autobot svcnemo-autobot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Background

Run 30245218834 failed because verl could not import a removed Megatron-LM API and skipped Megatron backend registration.

What changed

  • Keep verl and Megatron-LM on main.
  • Make Energon optional for non-Energon Bridge use.
  • Pin Transformers to 5.12.1 in verl suites.
  • Respect Megatron-LM’s Python metadata.

Details

Energon runtime code is imported lazily, and its builder tests patch that runtime module. Transformers 5.3 lacked Exaone4_5_ForConditionalGeneration; 5.12.1 is the immutable version installed before the successful local suites. The MCore API fix is NVIDIA/Megatron-LM#6065.

Tested

  • Full pre-commit gate, shell syntax, and git diff --check
  • Energon builder + module-layout tests: 19 passed
  • Clean Python 3.12 pip dry run for Megatron-LM main
  • Exact 8-GPU Qwen3, DeepSeek, and MoE suites completed successfully with Transformers 5.12.1 installed before their dependency resolves

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner July 27, 2026 10:17
@svcnemo-autobot
svcnemo-autobot requested a review from ko3n1g July 27, 2026 10:17
@svcnemo-autobot svcnemo-autobot added needs-more-tests Requires additional L0 and L1 test coverage before merge labels Jul 27, 2026
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 7af40e1

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test d9f4f7f

@yaoyu-33 yaoyu-33 added area:ci ci CI, automation, test queue, or workflow infrastructure work needs-review PR is ready for code review and waiting on a reviewer labels Jul 27, 2026
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot svcnemo-autobot changed the title fix(ci): AUT-1100 pin verl weekly test revision fix(ci): AUT-1100 align verl MCore compatibility ref Jul 27, 2026
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test d5b4d17

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 61c2665

## Use our checkout
pip3 install git+https://github.com/NVIDIA-NeMo/Megatron-Bridge.git@main --no-deps --no-build-isolation
pip3 install git+https://github.com/NVIDIA/Megatron-LM.git@main --no-deps --no-build-isolation
pip3 install git+https://github.com/NVIDIA/Megatron-LM.git@main --ignore-requires-python --no-deps --no-build-isolation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svcnemo-autobot why do we need --ignore-requires-python?

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

💬 --ignore-requires-python was introduced while testing an older pinned MCore commit. It is not needed now: Megatron-LM main requires Python ≥3.12, and the verl image runs Python 3.12. The flag only bypasses valid package metadata, so I’m removing it from all three scripts and validating in ci-events-agent-write-42f06dbb; parking on workload_phase{Running}.

@copy-pr-bot

copy-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 3134459

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 66f1c27

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 4650406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci ci CI, automation, test queue, or workflow infrastructure work full-test-suite needs-more-tests Requires additional L0 and L1 test coverage before merge needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants