Fix generic target not compiling - #38
Open
ZeoNyph wants to merge 8 commits into
Open
Conversation
|
I will relay test results on saturday 01/08/2026. |
|
lgtm! |
sebastianbrooker2
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some missing tweaks to the Dockerfile, as well as TensorRT, in order to allow compilation of code for local testing.
I finished work on this at Incheon, but decided not to actually bring it in, as it wasn't necessary for K1 development at the time.
Bringing this in now as I know @JohanneMontano has his NUsim PR which also has similar fixes, and I probably want to bring this in first since it's way smaller in scope to start with.