Fix _set_cam_chunk_size: use bps.unstage/bps.stage - #29
Draft
Max Rakitin (mrakitin) wants to merge 1 commit into
Draft
Fix _set_cam_chunk_size: use bps.unstage/bps.stage#29Max Rakitin (mrakitin) wants to merge 1 commit into
_set_cam_chunk_size: use bps.unstage/bps.stage#29Max Rakitin (mrakitin) wants to merge 1 commit into
Conversation
… comments Replace direct detector.unstage()/stage() calls with bluesky plan primitives bps.unstage()/bps.stage() so bluesky's staged-objects registry stays consistent and errors during unstage are not silently swallowed. Add comments explaining why: 1. bps.configure triggers _current_stream_cache-based descriptor re-preparation 2. test_scan2 must use dark → primary → background order (background stream omits motors, leaving _current_stream_cache without motors; a subsequent bps.configure would then KeyError when re-preparing the motor-inclusive 'dark' descriptor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct
detector.unstage()/detector.stage()calls with bluesky plan primitivesbps.unstage()/bps.stage()so bluesky's staged-objects registry stays consistent and errors during unstage are not silently swallowed.Why the error happened before:
Need to test it at the beamline before merging.