-
Notifications
You must be signed in to change notification settings - Fork 3
Implement a fix_convolution method
#368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
|
With this, I believe this is now done. |
cschwan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the following situation is covered: one PDF + one FF and you integrate out the PDF, thereby getting rid of the factorization scale (logs). Can you check that?
|
This is almost perfect, can you please add the following tests to up the code coverage: call
Ideally we'd also test missing the missing coverage where DIS+FF-grid's first convolution is fixed, but I can imagine creating such a grid isn't easy. |
The following PR allows fixing one of the convolutions and return a new Grid with lower dimension. For eg. it can be used to convert a SIDIS grid into DIS.
TODO:
cc @vbertone