299 custom reason for application rejection#341
Open
odracir04 wants to merge 8 commits into
Open
Conversation
|
Your Render PR Server URL is https://nijobs-backend-pr-341.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cljo2o98mmjc73bijve0. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #341 +/- ##
===========================================
- Coverage 90.34% 90.33% -0.01%
===========================================
Files 54 54
Lines 1470 1469 -1
Branches 246 245 -1
===========================================
- Hits 1328 1327 -1
Misses 137 137
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Author
|
it's worth mentioning that we had to alter the tests to include the new rejection messages but the tests cover the new code |
Naapperas
requested changes
Dec 6, 2023
Collaborator
|
@odracir04 please rebase and update the |
b384d98 to
8992eff
Compare
f038ecc to
47b92c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the reason in the rejection email is now allowed to be specified by admins in the post request.