Skip to content

fix(api): avoid Unicode tag extraction in compound search - #1541

Open
NishaSharma14 wants to merge 2 commits into
developmentfrom
issue-#1538
Open

fix(api): avoid Unicode tag extraction in compound search#1541
NishaSharma14 wants to merge 2 commits into
developmentfrom
issue-#1538

Conversation

@NishaSharma14

Copy link
Copy Markdown
Contributor

Match compound tag searches against generated tag slugs instead of extracting translated tag names. This avoids PostgreSQL SQL_ASCII failures when production tag JSON contains escaped Unicode values such as Greek symbols.

Validated with:
./vendor/bin/sail artisan test tests/API/SearchControllerTest.php

Match compound tag searches against generated tag slugs instead of extracting
translated tag names. This avoids PostgreSQL SQL_ASCII failures when production
tag JSON contains escaped Unicode values such as Greek symbols.

Validated with:
./vendor/bin/sail artisan test tests/API/SearchControllerTest.php
@NishaSharma14 NishaSharma14 self-assigned this Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.26%. Comparing base (8681915) to head (70f5430).

Files with missing lines Patch % Lines
app/Http/Controllers/API/SearchController.php 91.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             development    #1541   +/-   ##
==============================================
  Coverage          80.26%   80.26%           
- Complexity          4481     4483    +2     
==============================================
  Files                293      293           
  Lines              16424    16430    +6     
==============================================
+ Hits               13182    13187    +5     
- Misses              3242     3243    +1     
Flag Coverage Δ
unittests 80.26% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search API returns 500 for valid tag queries on /api/v1/search/compounds

1 participant