fix(api): avoid Unicode tag extraction in compound search - #1541
Open
NishaSharma14 wants to merge 2 commits into
Open
fix(api): avoid Unicode tag extraction in compound search#1541NishaSharma14 wants to merge 2 commits into
NishaSharma14 wants to merge 2 commits into
Conversation
Match compound tag searches against generated tag slugs instead of extracting translated tag names. This avoids PostgreSQL SQL_ASCII failures when production tag JSON contains escaped Unicode values such as Greek symbols. Validated with: ./vendor/bin/sail artisan test tests/API/SearchControllerTest.php
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1541 +/- ##
==============================================
Coverage 80.26% 80.26%
- Complexity 4481 4483 +2
==============================================
Files 293 293
Lines 16424 16430 +6
==============================================
+ Hits 13182 13187 +5
- Misses 3242 3243 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match compound tag searches against generated tag slugs instead of extracting translated tag names. This avoids PostgreSQL SQL_ASCII failures when production tag JSON contains escaped Unicode values such as Greek symbols.
Validated with:
./vendor/bin/sail artisan test tests/API/SearchControllerTest.php