Development - #1523
Merged
Merged
Conversation
Selector files in study NMRium payloads often carry archive/S3 prefixes that never share the stored relative_url of the dataset, so path-based matching silently dropped spectra. Match on study/dataset folder names first (mirroring the study NMRium save path) and keep relative_url as a fallback needle.
Backfills datasets that lack their own NMRium row by copying matched spectra from the parent study payload. Supports scoping by dataset or study, dry runs, chunked processing with a limit, and optional refresh of the denormalized spectra columns.
Accepting a project invitation attached the member, but clicking the shared project returned 403 because the dashboard routes private draft-stage projects into the draft editor and DraftPolicy::updateDraft only allowed the draft owner. Grant updateDraft to members with project update rights (creator, owner, collaborator) and route reviewers to the read-only project page instead of the draft editor.
Private studies returned 403 on /studies/{id}/nmriumInfo because the
reviewer obfuscation URL was not accepted on that follow-up request.
Unpublished reviewer preview pages have no public identifier, so the schema request must not run until one exists.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
============================================
+ Coverage 80.18% 80.34% +0.16%
- Complexity 4385 4416 +31
============================================
Files 289 289
Lines 16189 16241 +52
============================================
+ Hits 12981 13049 +68
+ Misses 3208 3192 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.