Skip to content

Feature #104 customization - #106

Merged
JohnHalleyGotway merged 16 commits into
mainfrom
feature_104_customization
Aug 5, 2026
Merged

Feature #104 customization#106
JohnHalleyGotway merged 16 commits into
mainfrom
feature_104_customization

Conversation

@jprestop

Copy link
Copy Markdown
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Reviewed the changes in this branch online and compared with the changes requested in the issue.

Confirmed that the Gallery was removed:

The issue notes three customization additions:

  • Encourage users to update physics_suite = 'CONUS' to 'tropical' to observe changes to physics suite and their impact on output. (Added in the WRF section)

  • Create a mask to restrict range of focus to a smaller domain via METplus (Added in the METplus section)

  • Introduce TMP thresholds to create temperature categories of interest (Added in the METplus section)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the added documentation to ensure it is sufficient.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [At your convenience].

Pull Request Checklist

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop linked an issue Jul 28, 2026 that may be closed by this pull request
20 tasks
@jprestop

Copy link
Copy Markdown
Collaborator Author

@jaredalee and @JohnHalleyGotway
I wasn't sure who to assign this to, so I added you both, but I assume that one approval is good.

@JohnHalleyGotway JohnHalleyGotway changed the title Feature 104 customization Feature #104 customization Jul 30, 2026
@JohnHalleyGotway
JohnHalleyGotway removed the request for review from jaredalee July 30, 2026 16:23
Comment thread docs/Users_Guide/customization.rst Outdated
Comment thread docs/Users_Guide/customization.rst
jprestop and others added 2 commits July 30, 2026 17:07
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Comment thread docs/Users_Guide/customization.rst

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julie, I tentatively approve this PR, but recommend you consider the suggestions I made. In particular, the embedded whitespace in the list of thresholds would cause a runtime error.

I did test these instructions on derecho and note the following:

Warning

The module load instructions failed in 2 spots!

  1. The module load on this page failed:
module load charliecloud apptainer gcc cuda ncarcompilers

I had to run:

module load ncarenv/24.12 charliecloud apptainer gcc cuda ncarcompilers

Since ncarenv/24.12 is no longer the default. Note that this change is needed in AT LEAST 2 spots in the instrutions.

  1. Unpacking the GEOG data with tar -xvzf ${WORKING_DIR}/geog_high_res_mandatory.tar.gz -C ${WORKING_DIR} takes an VERY long time (maybe like 30+ minutes!?).

Would be nice if we could just point to a common spot on the filesystem where WPS_GEOG data already exists.

I ran out of time to actually test the customizations. But I was glad to make it through the original run of hurricane matthew on derecho.

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some additional changes on this branch, and I tested that the customization instructions work on derecho.

However, I do note that the GenVxMask addition does NOT currently work, but only because I-WRF is currently using METplus version 6.0.0. Once we update it to a newer version of METplus, the GenVxMask customization will work.

Comment thread docs/Users_Guide/customization.rst Outdated
@jprestop

jprestop commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

@JohnHalleyGotway Thank you for your changes and updates. I found one typo where there was a duplication of "use" - "Hurricane Matthew use use case", so I removed that. Unfortunately, that got rid of your approval and I don't have permissions on this repo to override and squash and merge. I'll add @jaredalee to this comment, @JohnHalleyGotway since you're on PTO.

Maybe Jared can provide a quick approval and/or squash and merge himself. Jared, John recommended that I look over the changes he pushed to the branch to make sure the language is clear and there weren't typos. He had approved and said to merge, but when I fixed a typo, it got rid of his approval.

@JohnHalleyGotway
JohnHalleyGotway self-requested a review August 5, 2026 15:42
@JohnHalleyGotway
JohnHalleyGotway merged commit a9ee476 into main Aug 5, 2026
2 checks passed
@JohnHalleyGotway

JohnHalleyGotway commented Aug 5, 2026 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove, update chapter content

3 participants