Skip to content

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Nov 13, 2025

No description provided.

@coveralls
Copy link

coveralls commented Nov 13, 2025

Coverage Status

coverage: 62.706%. remained the same
when pulling 515488b on cleanup/reformat
into 00f637f on main.

@oliverklee

This comment was marked as outdated.

JakeQZ

This comment was marked as outdated.

@oliverklee oliverklee force-pushed the cleanup/reformat branch 2 times, most recently from 5e68f68 to 6f018dc Compare December 5, 2025 11:36
@oliverklee oliverklee marked this pull request as ready for review December 5, 2025 11:37
@oliverklee oliverklee requested a review from JakeQZ December 5, 2025 11:37
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we first have some further fixes to the strings so that they are not cluttering up the view of the code (i.e. put together with concatenation if necessary).

Comment on lines +22 to +23
self::assertSame(
'/** Number 11 **/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't read this.

@oliverklee
Copy link
Collaborator Author

Could we first have some further fixes to the strings so that they are not cluttering up the view of the code (i.e. put together with concatenation if necessary).

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants