Open
Conversation
Collaborator
|
Staging build: MyCryptoBuilds |
224d9ad to
a1a86de
Compare
1551506 to
0a26eb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4238 +/- ##
==========================================
+ Coverage 78.73% 79.40% +0.66%
==========================================
Files 572 575 +3
Lines 12429 12593 +164
Branches 3068 3149 +81
==========================================
+ Hits 9786 9999 +213
+ Misses 2611 2564 -47
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
FrederikBolding
requested changes
Jan 27, 2022
Collaborator
FrederikBolding
left a comment
There was a problem hiding this comment.
This was a big one. Sorry in advance 😅
Missing a bunch of tests, possibly a LS migration, should follow more of our code standards and possibly just a bit more polish.
Let me know if you have any questions about any comments - I suspect we'll need to iterate a bit on this before merging 👍
Since the PR is large I asked Maarten to take a look as well.
Mrtenz
requested changes
Jan 27, 2022
…g other requested changes
65ced7e to
d76407c
Compare
YocoBear
approved these changes
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes changes to txReceipt types and make tx history panel and tx status panels more useful.
Changes
ITxReceipttypes to handle valueTransfers (so we can display more than one asset transfer in txhistory and txstatus panels at a time).mtimes to be1234567891011in fixtures, so it's easier to test against them.