Merged
Conversation
added 5 commits
March 20, 2026 18:18
fix libssh2 import lib name for windows build handle libssh2 or ssh2 libraries Remove clang compiler settings from build workflow Update build workflow to specify C and C++ compilers for Windows build Refactor CMakeLists.txt to conditionally apply compiler options for non-MSVC builds Refactor type casting in Git-related classes for consistency and clarity clang style fix Add NOMINMAX definition for Windows compatibility and adjust exception filter declaration Skip wincred helper for MSVC builds in CMakeLists.txt to ensure compatibility with cl.exe
… for improved performance
Owner
|
Thank you very much! |
Murmele
reviewed
Mar 24, 2026
…atic and shared libraries are built. Remove outdated import library handling for libssh2.
Murmele
requested changes
Mar 25, 2026
added 2 commits
March 25, 2026 14:10
…for better type safety and update related usages in RepoView.
…ttyup into build_fixes_for_win_mac
BrendenWalker
force-pushed
the
build_fixes_for_win_mac
branch
from
3ed7b29 to
b1b5e5f
Compare
Murmele
reviewed
Mar 28, 2026
Owner
|
Maybe the following comment could be interesting as well? b89301d#commitcomment-181010141 |
Author
Replied in that thread. |
Murmele
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libssh2integration issues (libssh2vsssh2import-lib naming).libssh2.dllruntime dependency.set-outputreplacement).