Skip to content

fix CI warnings #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Murmele wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix CI warnings #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d4768
fix warnings
Murmele Jan 27, 2023
13a13fd
Update build.yml
Murmele Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,16 @@ jobs:
run: |
cd build/release
ninja package

# version is exported from cmake to file
- name: Retrieve version
run: |
VER=$(cat build/release/VERSION.txt)
echo "VERSION=$VER" >> $GITHUB_ENV

- name: Print version
run: |
echo ${{ env.VERSION }}

# Command copied from flathub build process
- name: Validate appdata file
Expand Down Expand Up @@ -306,7 +316,7 @@ jobs:

- name: Test
if: matrix.env.ninja_platform != 'win' && matrix.env.ninja_platform != 'mac'
uses: GabrielBB/xvfb-action@v1
uses: GabrielBB/xvfb-action@v1.6
with:
working-directory: build/release
run: ninja check
Expand Down Expand Up @@ -347,8 +357,12 @@ jobs:
# version is exported from cmake to file
- name: Retrieve version
run: |
echo "::set-output name=VERSION::$(cat artifacts/Gittyup-VERSION/VERSION.txt)"
id: version
VER=$(cat artifacts/Gittyup-VERSION/VERSION.txt)
echo "VERSION=$VER" >> $GITHUB_ENV

- name: Print version
run: |
echo ${{ env.VERSION }}

- name: Update GitHub release (latest tag)
uses: marvinpinto/action-automatic-releases@latest
Expand All @@ -370,7 +384,7 @@ jobs:
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
prerelease: false
title: Gittyup Release ${{ steps.version.outputs.VERSION }}
title: Gittyup Release ${{ env.VERSION }}
automatic_release_tag: ${{ github.ref_name }}
files: |
**/artifacts/Gittyup win64/Gittyup*.exe
Expand Down