PDF direct "Open with NiimBlue" on Android#134
Open
cryotato wants to merge 9 commits into
Open
Conversation
|
Could you also allow this for images and similar file types? (e. g. Text/Link) Or does it support this already? Also if possible to register NiimBlues as a PrinterService, to pass content that way too, but that may be indeed out of scope form this PR. |
Author
Hii it's very possible but I personally don't have as much use for that feature but if I have time I might give it a shot :) |
MultiMote
reviewed
Jun 11, 2026
|
|
||
| PdfRenderer.Page page = renderer.openPage(0); | ||
|
|
||
| int width = 800; |
MultiMote
requested changes
Jun 11, 2026
MultiMote
left a comment
MultiMote
left a comment
Owner
There was a problem hiding this comment.
Check comments and restore line endings at EOF please
|
|
||
| window.addEventListener("hashchange", loadLabelFromUrl); | ||
|
|
||
| // --- PDF INTENT LOGIC START --- |
Owner
There was a problem hiding this comment.
Can you extract this to function?
| ); | ||
|
|
||
| // 2. Automatically save to local storage whenever it changes | ||
| automation.subscribe((value) => { |
Owner
There was a problem hiding this comment.
There is writablePersisted for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a fork that is able to directly open PDFs. This is useful for things like a repairdesk system that automatically creates PDF labels from the browser.