-
Notifications
You must be signed in to change notification settings - Fork 36
Actually-useful-skill-framework ft. no runescape grinding and no annoying rng checks #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MrMelbert
wants to merge
27
commits into
master
Choose a base branch
from
medskill_2025
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cherry Picked
We're behind on schedule; and this is something we fucking need
Non-Module Code
Touches main files. Proceed with caution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the skill framework to be useful for more than just one-off memes kills like gaming.
Adds a variety of skills. Some jobs start with varying levels of these.
The goals of these skills are NOT to encourage people grind to max level at the start of the round, like old surgery skill - Hence why these skills are strictly non-grindable, and many jobs spawn with high levels in these skills.
Likewise the goals of these skills are NOT to punish people for TRYING to do a job they are not trained to do - Hence why there are no annoying Bay-style RNG checks "you fumble the suture, and now you're bleeding even more lol!".
Some skills make you slightly worse if you are COMPLETELY untrained, but not in an insurmountable fashion. For example, if you are not trained in surgery, using Sterilizine will offset the minor penalty.
The goal is to make people who are intended to do a job better at the job than everyone else, giving the player more purpose.
You are encouraged to seek out a doctor to get an operation, rather than the chef, because the doctor will get it done faster and with less hassle.
You are encouraged to seek out the roboticist to get augmented, rather than the coroner, because the roboticist's augments result in less pain being applied.
In both cases nothing is stopping you from asking the chef or coroner, they still CAN accomplish these things, just less effectively.
Also, people like flexing that they're good at things, so this gives people an in character way to do that.
The following skills have been added
TRAIT_KNOW_ENGI_WIRES(knowledge of airlock and apc wires)TRAIT_CPR_CERTIFIED(ability to perform CPR without damaging the patient)