feat: send BeforeDisconnectEvent before disconnecting clients#5077
Draft
jdrueckert wants to merge 2 commits into
Draft
feat: send BeforeDisconnectEvent before disconnecting clients#5077jdrueckert wants to merge 2 commits into
jdrueckert wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Type: Improvement
jdrueckert
added a commit
to Terasology/LightAndShadow
that referenced
this pull request
Nov 6, 2022
- create PlayerExitedArenaEvent - on arena exit remove AllowShopScreenComponent (players only need the shop in-game) - move check for condition changes that trigger a phase change into LASSystem - switch player to white team instead of removing LASTeam component - trigger arena exit clean up actions for disconnecting clients before they are disconnected (requires MovingBlocks/Terasology#5077)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains
A new
BeforeDisconnectEventevent that is sent before disconnecting clients to allow, e.g. component clean-ups on the disconnecting player's entity.Required by Terasology/LightAndShadow#256