Stackable Support Abilities#335
Open
happypurpleduck wants to merge 3 commits intoMotocalDevelopers:masterfrom
Open
Stackable Support Abilities#335happypurpleduck wants to merge 3 commits intoMotocalDevelopers:masterfrom
happypurpleduck wants to merge 3 commits intoMotocalDevelopers:masterfrom
Conversation
Collaborator
// global_const.js assume support data
{
"saikou_ni_kure": {
"name": "saikou_ni_kure",
"type": "composite",
"range": "own",
"stages": ["0", "1", "2", "3", "4", "5"],
"middleware": ["stage-mul"],
"value": [
{"type": "otherBuff", "value": 0.20, "assign": "max"},
{"type": "damageLimitBuff", "value": 0.03},
{"type": "DATASupport", "value": [0.20, 0.40]},
{"type": "ougiDamageBuff", "value": 0.10},
{"type": "ougiDamageLimitBuff", "value": 0.05},
]
}
}
Actual data earchSupport generate and treatSupportAbility will receive {
"type": "otherBuff",
"range": "own",
"value": 0.4,
"assign": "max",
}
|
Collaborator
|
I had sent wrong, while editing ... it not completed message yet.
I have idea to implement this, I will explain or PR later (when got a time) |
Collaborator
|
it's now implemented just test snippet (in progress) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will include Support Abilities that has varied number of values based on stacks like Hallessena's Downright Crazy! or other "simple" values like Athena's Searing Crimson.
target is Burned condition and likes (based on target condition) could be generalized later on (and added beside Sun-Touched Paradise/etc.
Add Support Abilities
Fire
Water
Earth
Wind
Light
Dark
extra:
Not so related support abilities. (todo probably in another PR):
Add Support Abilities #339
Bonus Damage Stacking