Feature/parity with python wrapper by Karvel · Pull Request #14 · Montage-Inc/javascript-montage

Karvel · 2016-08-02T22:04:05Z

Added delete function to API scripts and deprecated remove functions.
Added Field tests.
Updated Query to use named parameters/objects.
Updated Query tests to match new Query functions.

TODO

Fix between() refactor in Query script and update respective test.
Fix orderBy() refactor in Query script and update respective test.
Finish tests for API scripts.
Add unit test for delete function in Query.

…r with a feature deprecated message on using remove

…th a feature deprecated message on using remove

…with a feature deprecated message on using remove

…th a feature deprecated message on using remove

…with a feature deprecated message on using remove

…th a feature deprecated message on using remove

…$`, add depreciation warning when using argument without `$`

…ntage` wrapper

…y.js` - orderBy, between, getIntersecting, and getNearest still not passing

… parameters

Karvel · 2016-08-03T21:40:26Z

Updated to close #10.

…egex operator.

Karvel · 2016-08-11T23:44:54Z

Also closes #17.

…ge-Inc/javascript-montage into feature/parity-with-python-wrapper

feat(task): add task endpoint to wrapper

feat(project): add project API endpoint

dmpayton · 2016-09-06T23:19:10Z

+		return this.client.request(`project`);
+	}
+
+	update(name, subdomain) {


@Karvel: Please sprinkle in a bit of destructuring here.

…ons read more naturally

nick-herrera · 2016-09-19T16:27:45Z

+	describe('#istarts()', () => {
+		it('should equal a filter with a value of $istarts', () => {
+			let expectedFilter = [['$eq', 'y']];
+			expect(field.eq('y').filters).to.eql(expectedFilter);


This tests eq() instead of istarts()

Addressed in a4c65e4.

nick-herrera · 2016-09-19T22:15:09Z

@dmpayton @Karvel Should Field.contains() be removed as requested in issue #17? The above conversation says that it closes #17, but I don't see how.

@Karvel are the Query.between() and Query.orderBy() refactors you mention in your to-do list complete?

@dmpayton do you want to wait on implementing tests for the API classes (document, file, etc)?

I'd recommend implementing a unit test for Query.delete(). Also, Query.filter() and Query.group() don't have any tests. Finally, the test for Field.istarts() actually tests Field.eq()

Karvel · 2016-09-19T22:59:49Z

@nick-herrera I erroneously thought that 66dae52 addressed #17. I took care of it in a062c1f.

dmpayton · 2016-09-20T07:13:37Z

I'm cool with merging this once the 4 TODOs in the original comment are complete.

…accordingly.

Karvel added 24 commits July 15, 2016 10:01

refactor(document): remove function to match python wrapper

b21feb4

refactor(document api): replace remove function with delete; warn use…

a5ebba5

…r with a feature deprecated message on using remove

refactor(file api): replace remove function with delete; warn user wi…

272c2d8

…th a feature deprecated message on using remove

refactor(policy api): replace remove function with delete; warn user …

f74122f

…with a feature deprecated message on using remove

refactor(role api): replace remove function with delete; warn user wi…

85f1c0d

…th a feature deprecated message on using remove

refactor(schema api): replace remove function with delete; warn user …

7c42722

…with a feature deprecated message on using remove

refactor(user api): replace remove function with delete; warn user wi…

4f5dd5e

…th a feature deprecated message on using remove

refactor(query): update Query object to pass in named parameters/objects

badcabd

refactor(query): update orderBy ordering with precede argument with `…

e7a985d

…$`, add depreciation warning when using argument without `$`

style(query): moved function to match python-montage wrapper

a2bcb44

docs(query): add comments for function groups to match the `python-mo…

21c8056

…ntage` wrapper

feat(query): add delete function to match the python-montage wrapper

bc5beba

test(field): add tests for each function in field.js

500793a

refactor(query): rename arguments to match the python-montage wrapper

8b430e1

refactor(query): fix logic typo

63eb9ca

test(query): update tests to work with new object parameters in `quer…

12ff867

…y.js` - orderBy, between, getIntersecting, and getNearest still not passing

fix(query): rewrite remaining functions to work correctly with object…

9c1d2b1

… parameters

test(query): update remaining tests to work with updated query.js

d7e00f7

fix(field): change parameter from spread operator

f390f05

feat(tasks): import TaskAPI to Client script

60860d6

feat(tasks): add TaskAPI script to match the python-montage wrapper

101bc0d

fix(task): update object name to match server-side name

4d431af

refactor(field): update inSet() to in(); deprecate inSet()

9daef5d

test(field): update inSet() test to reference in()

e8c1f86

juliancoleman mentioned this pull request Aug 4, 2016

Fix/54 query builder filters Montage-Inc/montage-frontend#61

Merged

dmpayton added 2 commits August 11, 2016 15:59

feat(field): Add a $match operator to replace the (now deprecated) $r…

66dae52

…egex operator.

Add filters to the already-implemented api list methods.

3290bcc

refactor(client): rename project to subdomain

9baafed

Karvel mentioned this pull request Sep 6, 2016

feat(task): add task endpoint to wrapper #20

Merged

dmpayton added 3 commits September 6, 2016 15:59

Merge branch 'feature/parity-with-python-wrapper' of github.com:Monta…

899411f

…ge-Inc/javascript-montage into feature/parity-with-python-wrapper

Merge pull request #20 from Montage-Inc/feature/15-add-tasks

a5cc17c

feat(task): add task endpoint to wrapper

Merge pull request #19 from Montage-Inc/feature/18-project-api

38fddfe

feat(project): add project API endpoint

dmpayton reviewed Sep 6, 2016
View reviewed changes

Karvel and others added 8 commits September 6, 2016 16:42

refactor(project): make optional arguments into options object

fb203b4

refactor(api): check for payload object length before returning

eba24cf

Merge branch 'feature/v3' into feature/parity-with-python-wrapper

a21575e

refactor(tests): change .to.be.eql() to .to.eql() so that asserti…

c5cc5f8

…ons read more naturally

style(misc): add missing semi-colons

f326a6e

style(query_test): remove unnecessary quotes from property name

81a704b

style(query_test): add missing semicolon

c18cd37

refactor(client_test): remove unused Query import

b9d2108

nick-herrera reviewed Sep 19, 2016

View reviewed changes

refactor(field): remove obsolete code

a062c1f

Karvel added 3 commits September 19, 2016 16:00

test(field_test): remove dead code test

236d145

test(field_test): fix test to use correct field

a4c65e4

test(field_test): finish updating test

25478aa

Karvel and others added 9 commits September 21, 2016 10:38

test(query_test): add test for group

1a69190

test(query_test): add test for delete

4b603b1

Merge branch 'feature/v3' into feature/parity-with-python-wrapper

ba0db4c

Rewrite Query.filter(). Untested. ¯\_(ツ)_/¯

88b3677

Re-Rewrite Query.filter(). Untested. ¯\_(ツ)_/¯

6f858e4

test(query_test): add early implementation of filter tests

4a6d800

Rewrite Field operators and modifiers to return their data, and test …

d8781d8

…accordingly.

Add .editorconfig

859e554

Style: Fix indentation to match .editorconfig.

377315b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/parity with python wrapper#14

Feature/parity with python wrapper#14
Karvel wants to merge 56 commits intofeature/v3from
feature/parity-with-python-wrapper

Karvel commented Aug 2, 2016 •

edited

Loading

Uh oh!

Karvel commented Aug 3, 2016

Uh oh!

Karvel commented Aug 11, 2016

Uh oh!

dmpayton Sep 6, 2016

Uh oh!

nick-herrera Sep 19, 2016

Uh oh!

Karvel Sep 19, 2016

Uh oh!

nick-herrera commented Sep 19, 2016 •

edited

Loading

Uh oh!

Karvel commented Sep 19, 2016

Uh oh!

dmpayton commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Karvel commented Aug 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Karvel commented Aug 3, 2016

Uh oh!

Karvel commented Aug 11, 2016

Uh oh!

dmpayton Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

nick-herrera Sep 19, 2016

Choose a reason for hiding this comment

Uh oh!

Karvel Sep 19, 2016

Choose a reason for hiding this comment

Uh oh!

nick-herrera commented Sep 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Karvel commented Sep 19, 2016

Uh oh!

dmpayton commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Karvel commented Aug 2, 2016 •

edited

Loading

nick-herrera commented Sep 19, 2016 •

edited

Loading