feat: Adding Editor Network Stats #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Trying to add resizable columns to the multi-column table but the web view implementation doesn't support it apparently - Added some support for column variants (previously, it assumed all columns were the same numeric format) - Added new columns for packet sizes into the Editor pane
dacowan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Editor Network Stats visualization to the diagnostics panel, along with several infrastructure improvements to support multi-column statistics display.
Key Changes:
- Introduced a new
MinecraftMultiColumnStatisticTablecomponent for displaying dynamic multi-column data tables with flexible column configurations - Fixed aggregation logic in the statistics provider to handle events with multiple numeric values per child
- Added CSS styling for enhanced table column headers with visual resize indicators
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
webview-ui/src/diagnostics_panel/prefabs/tabs/EditorNetworkStats.tsx |
New tab component for displaying editor network packet statistics with 4 value columns (Sent Count, Received Count, Min Size, Max Size) |
webview-ui/src/diagnostics_panel/prefabs/index.tsx |
Registers the new EditorNetworkStats tab in the diagnostics panel |
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx |
New reusable table component supporting dynamic multi-column displays with sorting, prettify options, and multiple data processing paths |
webview-ui/src/diagnostics_panel/StatisticProvider.tsx |
Enhanced MultipleStatisticProvider to allow events with children_string_values even when values array is empty |
webview-ui/src/diagnostics_panel/App.css |
Added comprehensive styling for multi-column grid including column headers, resize handles, and fixed column widths |
src/stats/stats-provider.ts |
Extended aggregateData method to handle both single and multiple numeric values per child stat, converting them to string arrays |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx
Outdated
Show resolved
Hide resolved
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx
Outdated
Show resolved
Hide resolved
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx
Show resolved
Hide resolved
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx
Outdated
Show resolved
Hide resolved
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx
Show resolved
Hide resolved
webview-ui/src/diagnostics_panel/controls/MinecraftMultiColumnStatisticTable.tsx
Outdated
Show resolved
Hide resolved
…StatisticTable.tsx Co-authored-by: Copilot <[email protected]>
…StatisticTable.tsx Co-authored-by: Copilot <[email protected]>
…StatisticTable.tsx Co-authored-by: Copilot <[email protected]>
…StatisticTable.tsx Co-authored-by: Copilot <[email protected]>
- Fixed up column widths to be a little more realistic - Removed some duplicate code
- Fixed column widths was nasty, made them properties of the table
JakeShirley
approved these changes
Dec 15, 2025
JakeShirley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new debugger stats visualization for editor network statistics