Avoid duplicated reading RPN code execution across multiple clients#35
Open
cpuwolf wants to merge 1 commit intoMobiFlight:mainfrom
Open
Avoid duplicated reading RPN code execution across multiple clients#35cpuwolf wants to merge 1 commit intoMobiFlight:mainfrom
cpuwolf wants to merge 1 commit intoMobiFlight:mainfrom
Conversation
While multiple clients Add(MF.SimVars.Add.xxxxRPNcodexxx) the exact same SimVars to WASM,
From MSFS2020 perspective, it is unnecessary to execute the same RPNcode several times in each frame. This is an enhancement change to reduce FPS impact
WASM will smartly execute duplicated SimVars only once in each frame.
introduce new data structure:
//RPN code execution for reading values in every frame
struct ReadRPNCode {
std::string Code;
int RetType; //RetType: 0:float 1:integer 2:string
std::vector<SimVar> SimVars;
std::vector<StringSimVar> StringSimVars;
};
--
This patch is stable because we have 1000+ customers who have been using these changes over a year
GitHub Copilot suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a performance enhancement for handling multiple clients subscribing to identical SimVars. Currently, if multiple clients add the same RPN code (e.g., via MF.SimVars.Add), the WASM module executes the code redundantly for every instance within a single frame.
Changes:
Implemented a "calculate once, distribute to many" logic. The WASM module will now detect duplicate RPN codes and execute them only once per frame.
Introduced a new ReadRPNCode structure to manage the mapping of single code executions to multiple SimVars/StringSimVars.
Stability:
This patch is highly stable and production-ready. It has been deployed to over 1,000 customers for more than a year with no reported issues.