introactivity: allow to override onCreate again#2
Open
amartinz wants to merge 2 commits intoMizzleDK:masterfrom
Open
introactivity: allow to override onCreate again#2amartinz wants to merge 2 commits intoMizzleDK:masterfrom
amartinz wants to merge 2 commits intoMizzleDK:masterfrom
Conversation
* remove final from onCreate to allow overriding * as the library depends on calling onCreate, add a CallSuper annotation to tell the library user that super.onCreate has to be called Change-Id: Iee55651b080c05c6d655666a3c449d4ea5691b51 Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
Change-Id: I6d1490abb5e7dfcc15f58f97f0cb17f8b61aad0a Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
Owner
|
Thanks for all your pull requests! I'm sorry I haven't seen them before now. Will take a look at them within the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to tell the library user that super.onCreate has to be called
Change-Id: Iee55651b080c05c6d655666a3c449d4ea5691b51
Signed-off-by: Alexander Martinz eviscerationls@gmail.com