windows configurer: remove pre-delete race from Reboot()#626
Merged
james-nesbitt merged 1 commit intomainfrom Apr 30, 2026
Merged
windows configurer: remove pre-delete race from Reboot()#626james-nesbitt merged 1 commit intomainfrom
james-nesbitt merged 1 commit intomainfrom
Conversation
schtasks /run returns before shutdown.exe starts. The immediate schtasks /delete was cancelling the pending shutdown before it could fire, causing waitForHost to time out with 'still online'. Remove the pre-delete. The ONSTART task re-fires on next startup, which is safe: the post-reboot cleanup in InstallMCR deletes LaunchpadReboot once the host is back up.
Collaborator
Author
|
this change was missing from the previous merge. It got lost in a refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
schtasks /run returns before shutdown.exe starts. The immediate schtasks /delete was cancelling the pending shutdown before it could fire, causing waitForHost to time out with 'still online'.
Remove the pre-delete. The ONSTART task re-fires on next startup, which is safe: the post-reboot cleanup in InstallMCR deletes LaunchpadReboot once the host is back up.