Skip to content

feat: add type-level tests and improve test coverage#287

Open
thegreatfeez wants to merge 1 commit into
Miracle656:mainfrom
thegreatfeez:main
Open

feat: add type-level tests and improve test coverage#287
thegreatfeez wants to merge 1 commit into
Miracle656:mainfrom
thegreatfeez:main

Conversation

@thegreatfeez
Copy link
Copy Markdown

Summary

This PR introduces robust multi-layered testing infrastructure for the core SDK to protect against architectural regressions, while updating the marketing landing page to clearly articulate Veil's unique value proposition.

Related issue

Closes #257
Closes #260
Closes #261
Closes #262

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs
  • Tests
  • CI / tooling

Component

  • Wallet frontend
  • SDK
  • Contracts
  • Agent

Checklist

  • I have read CONTRIBUTING.md
  • cargo test passes (contracts)
  • npm run typecheck passes (wallet / sdk / agent)
  • npm run build passes (wallet / agent)
  • I added or updated tests where relevant
  • I updated docs / README where relevant

Description

This pull request implements stability enhancements, testing infrastructure, and critical positioning updates for both the SDK and the wallet frontend marketing components.

Key Deliverables

1. SDK Core Architecture & Stability

  • XDR Encoding Roundtrip Tests: Added sdk/tests/xdr-roundtrip.test.ts to execute end-to-end encode → decode → assert deep equality checks across all transaction builder helpers to eliminate subtle serialization mutations.
  • Type-Level Regression Suite: Established compile-time type assertions using tsd in sdk/test-d/index.test-d.ts (10+ type assertions tracking high-traffic SDK return types). Integrated npm run test-d into the pipeline via sdk/package.json.
  • State Format Pinning: Added a backward-compatibility snapshot test (sdk/tests/credential-format.test.ts) using a v1 fixture configuration (sdk/tests/fixtures/credential-v1.json) to prevent storage deserialization breaks for existing wallets. Codified and documented the project's long-term format-stability policy.

2. Frontend Marketing Positioning

  • Value Proposition Component: Designed and integrated frontend/website/components/WhyVeil.tsx into the main application landing page (frontend/website/app/page.tsx).
  • Competitive Contrast Matrix: Built a mobile-responsive comparison table contrasting Veil against legacy alternatives (Freighter and xBull), emphasizing its core architecture pillars:
    • No seed phrases
    • No browser extension requirements
    • Native Account Abstraction
  • Performance Metric Compliance: Validated layout structure to guarantee a Lighthouse accessibility score of $\ge 95$.

@thegreatfeez thegreatfeez requested a review from Miracle656 as a code owner June 1, 2026 21:13
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

@thegreatfeez is attempting to deploy a commit to the miracle656's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 1, 2026

@thegreatfeez Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Landing-page section: "Why Veil" Snapshot test for serialized passkey credential SDK type tests with tsd Stellar XDR roundtrip tests

1 participant