fix: Use @synchronized directive for breadcrumbs (#69)#71
Merged
velocitysystems merged 2 commits intomasterfrom Dec 12, 2025
Merged
fix: Use @synchronized directive for breadcrumbs (#69)#71velocitysystems merged 2 commits intomasterfrom
velocitysystems merged 2 commits intomasterfrom
Conversation
velocitysystems
force-pushed
the
mr/breadcrumbs
branch
from
219946c to
587c141
Compare
velocitysystems
changed the title
miquelbeltran
previously approved these changes
Dec 9, 2025
velocitysystems
commented
Dec 12, 2025
miquelbeltran
approved these changes
Dec 12, 2025
velocitysystems
force-pushed
the
mr/breadcrumbs
branch
from
67e003b to
d0340d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
#69
The app was crashing with "Collection was mutated while being enumerated" when breadcrumbs were being recorded concurrently from multiple threads. This occurred when one thread was iterating over
_mutableBreadcrumbsinupdateCrashReportUserInformationwhile another thread was adding or removing breadcrumbs.@synchronized(self)to protect all read and write operations.