extract data from mat file, reproject the facies and plot the virtual cores#4
extract data from mat file, reproject the facies and plot the virtual cores#4xyl96 wants to merge 17 commits into
Conversation
|
The plotting issue has been solved |
|
As a general feedback on this PR: it is not clear what the problem is. From the issue description #3 it seems to me that plotting the columns is the problem, but from the PR title it seems that extracting data from mat files is the problem. Which one is it? If it is the plotting that is needed, is there anything about these cores that requires writing completely new code for plotting columns? There are a bunch of packages for doing that, including our home one https://mindthegap-erc.github.io/stratcols/ by @NiklasHohmann So my general feedback:
|
| for idx in eachindex(core_layers_norm)[2:end] | ||
| top = core_layers_norm[idx] | ||
| bottom = core_layers_norm[idx-1] | ||
| if core_facies[idx] != 100 |
There was a problem hiding this comment.
why assign properties to hiatus (color and transparency) if it's never plotted?
There was a problem hiding this comment.
I added it specifically to check whether the codes are following what I want - it happens when I was writing the code.
reply:
|
works, but not elegant
EmiliaJarochowska
left a comment
There was a problem hiding this comment.
Not related to this PR specifically but more generally: please add README (don't hesitate to ask for help)
I think the main problem is storing all the mat files in the repo. Binary files cannot be tracked with git and they take a lot of space. It would probably make more sense to put them in Zenodo (separate repo) and download using datahugger? But you can ask @NiklasHohmann for a second opinion
In rastering.jl I get:
ERROR: KeyError: key "trackID" not found
Consider not tracking files that are generated in the code, just to keep the repo lean
Generally agree, keeping binary data on Zenodo and then autodownload it would be the smoothest option. |
Yes, the results mat file is provided in the zenodo. |
I think that wasn't the point of this comment ;-) The point was not to put them on GH but download from Zenodo |
ok, will add 'download' function in the plottingcores.jl |
delete useless files
|
I need the current version of the data for #5 so I'll merge off this branch |
|
In order to do this I need some info from @xyl96 TrackingHabitat/src/PlottingCores/plottingcores.jl Lines 14 to 15 in e73fac8 However, layers contains negative values:
etc
What I need for the power spectral densities are: x(t) : a vector showing facies class at the sampling point as a function of time step Actually what I am trying to do would probably benefit from some depth-to-time transfers of |
|
PS what I am trying to do is to compute Because the depth series has a different length than the time series, their PSDs are computed on their own grids and then interpolated to a common spatial frequency axis before taking the ratio. |
The layers means the 'water depth' so that's why they are negative. I think now it's 100 layers. |




Extracting the data from MAT file from STACKER, reproject the facies and plotting.